Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port collision when both gateway and reva loads gateway.toml #3

Closed
mirekys opened this issue Jun 2, 2020 · 2 comments
Closed

Port collision when both gateway and reva loads gateway.toml #3

mirekys opened this issue Jun 2, 2020 · 2 comments
Assignees
@SamuAlfageme
Labels
REVA

Comments

@mirekys
Copy link
Member

mirekys commented Jun 2, 2020 •
edited
Loading

There is a collision of used ports as both reva and gateway containers use
the same gateway.toml

Related: #2
@SamuAlfageme SamuAlfageme self-assigned this Jun 5, 2020
@SamuAlfageme
Copy link
Contributor

This is due to the -dev-dir (cs3org/reva#416) picking all the files mounted from the ConfigMap and the pod's network space being shared. I'll fix it by creating a second ConfigMap for the gateway and its cfg. files.

In a production-ready future, we shall not run multiple revad goroutines in just one container but rather have one container per config file (+ its additional json files).

SamuAlfageme added a commit to SamuAlfageme/cs3orgcharts that referenced this issue Jun 5, 2020
@SamuAlfageme
Create a separate ConfigMap for each revad container
40fb405 
This will also allow in the future to ditch running
the main 'revad' container with -dev-dir by mounting
their config (.toml, .json, ...) on the righ container

Fix: cs3org#3
@SamuAlfageme SamuAlfageme mentioned this issue Jun 5, 2020
Closed
2 tasks
SamuAlfageme added a commit to SamuAlfageme/cs3orgcharts that referenced this issue Jun 15, 2020
@SamuAlfageme
Create a separate ConfigMap for each revad container
778b2bd 
This will also allow in the future to ditch running
the main 'revad' container with -dev-dir by mounting
their config (.toml, .json, ...) on the righ container

Fix: cs3org#3
@SamuAlfageme
Copy link
Contributor

Won't reproduce again as we changed the pod layout after cs3org/reva#826 and removed the workDir and args parameters from the chart values to prevent using -dev-dir inside the pod in #7.

Thanks for reporting @mirekys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SamuAlfageme SamuAlfageme

Labels
REVA
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create a separate ConfigMap for each revad container SamuAlfageme/cs3orgcharts
2 participants
@mirekys @SamuAlfageme