Fix public link paths for file shares #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishank011
force-pushed
the
public-share
branch
from
a1a78ef to
dec35b0
Compare
ishank011
force-pushed
the
public-share
branch
from
dec35b0 to
313c5bb
Compare
|
@C0rby this takes care of the issue of why tests were failing in #2214 The download requests go to |
C0rby
approved these changes
Nov 19, 2021
labkode
approved these changes
Nov 22, 2021
|
the actual problem is that the Content-Disposition Header is wrong: I struggle to make chrome or edge show me actual download requests. But with firefox this can be seen. I'll comment with a proper fix ... |
butonic
added a commit
to butonic/reva
that referenced
this pull request
Nov 22, 2021
This reverts commit 29826a3.
labkode
pushed a commit
that referenced
this pull request
Dec 2, 2021
* make content disposition reflect request base path Signed-off-by: Jörn Friedrich Dreyer <[email protected]> * Revert "Fix public link paths for file shares (#2297)" This reverts commit 29826a3. * Add content disposition fix changelog Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.