Fix public link paths for file shares (#2297)

cs3org · Nov 22, 2021 · 29826a3 · 29826a3
1 parent 0ffb38f
commit 29826a3
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/changelog/unreleased/fix-public-share-paths.md b/changelog/unreleased/fix-public-share-paths.md
@@ -0,0 +1,3 @@
+Bugfix: Fix public link paths for file shares
+
+https://github.com/cs3org/reva/pull/2297
diff --git a/internal/grpc/services/publicstorageprovider/publicstorageprovider.go b/internal/grpc/services/publicstorageprovider/publicstorageprovider.go
@@ -154,7 +154,12 @@ func (s *service) translatePublicRefToCS3Ref(ctx context.Context, ref *provider.
 		return nil, "", nil, st, nil
 	}
 
-	cs3Ref := &provider.Reference{Path: path.Join("/", shareInfo.Path, relativePath)}
+	p := shareInfo.Path
+	if shareInfo.Type != provider.ResourceType_RESOURCE_TYPE_FILE {
+		p = path.Join("/", shareInfo.Path, relativePath)
+	}
+	cs3Ref := &provider.Reference{Path: p}
+
 	log.Debug().
 		Interface("sourceRef", ref).
 		Interface("cs3Ref", cs3Ref).

diff --git a/internal/http/services/owncloud/ocdav/publicfile.go b/internal/http/services/owncloud/ocdav/publicfile.go
@@ -55,7 +55,6 @@ func (h *PublicFileHandler) Handler(s *svc) http.Handler {
 				return
 			}
 
-			r.URL.Path = path.Base(r.URL.Path)
 			switch r.Method {
 			case MethodPropfind:
 				s.handlePropfindOnToken(w, r, h.namespace, false)
@@ -121,9 +120,6 @@ func (s *svc) adjustResourcePathInURL(w http.ResponseWriter, r *http.Request) bo
 		return false
 	}
 
-	// adjust path in request URL to point at the parent
-	r.URL.Path = path.Dir(r.URL.Path)
-
 	return true
 }
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		Bugfix: Fix public link paths for file shares

		https://github.com/cs3org/reva/pull/2297