fix app open when multiple app providers are present

[wkloucek]

Bugfix: Fix app open when multiple app providers are present

We've fixed the gateway behavior, that when multiple app providers are present, it always returned that we have duplicate names for app providers.
This was due the call to GetAllProviders() without any subsequent filtering by name. Now this filter mechanism is in place and the duplicate app providers error will only appear if a real duplicate is found.

Introduced in #2095

[glpatcern]

I had a look at the code but there's something I don't understand, will discuss it with @ishank011 and @gmgigi96.

[wkloucek]

I had a look at the code but there's something I don't understand, will discuss it with @ishank011 and @gmgigi96.

Is there something I can help you?

[ishank011]

@wkloucek looks good. Ideally filteredProviders should always have one element only but in case multiple apps are registered with the same name, should we raise an error?

[wkloucek]

@wkloucek looks good. Ideally filteredProviders should always have one element only but in case multiple apps are registered with the same name, should we raise an error?

That was already there (

reva/internal/grpc/services/gateway/appprovider.go

Lines 307 to 309 in 9c827f8

	// we should never arrive to the point of having more than one
	// provider for the given "app" parameters sent by the user
	return nil, errtypes.InternalError(fmt.Sprintf("gateway: user requested app %q and we provided %d applications", app, len(res.Providers)))

). Only the filter was missing

[ishank011]

Okay yes, my bad. Can you just move the code you added below the res.Status check please?

[ishank011]

Also, sorry for the repeated reviews, but can you also remove the check if p.Name == app { inside the block where we check that there's only one provider? It's redundant

[wkloucek]

Okay yes, my bad. Can you just move the code you added below the res.Status check please?

changed 👍

Also, sorry for the repeated reviews, but can you also remove the check if p.Name == app { inside the block where we check that there's only one provider? It's redundant

That should stay... Image the user requesting an app that doesn't exist. The user would then get the only app existing, which is not the app, the user requested.

[ishank011]

That should stay... Image the user requesting an app that doesn't exist. The user would then get the only app existing, which is not the app, the user requested.

But your code should take care of that, right?

[wkloucek]

That should stay... Image the user requesting an app that doesn't exist. The user would then get the only app existing, which is not the app, the user requested.

But your code should take care of that, right?

You're right, sorry...

[ishank011]

Perfect, thanks!