Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitelist apps #2095

Merged
merged 7 commits into from
Sep 28, 2021
Merged

Whitelist apps #2095

merged 7 commits into from
Sep 28, 2021

Conversation

gmgigi96
Copy link
Member

This PR introduces the following enhancements:

  1. Overrides the AppProvider supported mimetypes from the configuration
  2. Add a configuration for the mime types in the AppRegistry (a friendly name, default AppProvider, description, icon, ...)

@gmgigi96 gmgigi96 marked this pull request as ready for review September 23, 2021 16:57
@gmgigi96 gmgigi96 requested a review from labkode as a code owner September 23, 2021 16:57
@glpatcern glpatcern self-requested a review September 24, 2021 15:24
glpatcern
glpatcern reviewed Sep 24, 2021
View reviewed changes
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good, I just want to prepare a good list of default mime types to be included. Will do that on Monday ;-)

glpatcern
glpatcern requested changes Sep 27, 2021
View reviewed changes
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As quickly discussed, for the example config file I'd include the mime types for: docx, xlsx, pptx, odt, ods, odp, txt, md, root, ipynb.

internal/grpc/services/appregistry/appregistry_test.go Show resolved Hide resolved
glpatcern
glpatcern approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me!

@glpatcern glpatcern merged commit 48d4872 into cs3org:master Sep 28, 2021
This was referenced Sep 28, 2021
Merged
Merged
@gmgigi96 gmgigi96 mentioned this pull request Sep 30, 2021
Closed
9 tasks
@wkloucek wkloucek mentioned this pull request Sep 30, 2021
Merged
9 tasks
glpatcern pushed a commit to glpatcern/reva that referenced this pull request Nov 12, 2021
@gmgigi96 @labkode @glpatcern
Whitelist apps (cs3org#2095)
95b62cb 
* Fix logic for default mapping

* Override AppProvider supported mimetypes with the ones set in the config

* Add configuration in the AppRegistry for MimeTypes

* Add default AppProvider from the configuration

* Add changelog

* Update AppRegistry tests with the mimetypes infos from the config

* Add AppRegistry mime type examples and demo AppProvider

Co-authored-by: Hugo Gonzalez Labrador <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glpatcern glpatcern glpatcern approved these changes

@labkode labkode Awaiting requested review from labkode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gmgigi96 @glpatcern @labkode