add filter by sharetype in the ocs API

[C0rby]

Added a query parameter to the OCS API to filter the received shares by type.

[labkode]

Looks good to me but I need @butonic, @refs to approve as well.

[butonic]

The share_type parameter was introduced to oc10 with owncloud/core#38053

[butonic]

could you add the filter to the sql driver in

reva/pkg/share/manager/sql/sql.go

Line 278 in eacfb8a

if f.Type == collaboration.Filter_TYPE_RESOURCE_ID {

and maybe in

reva/pkg/cbox/share/sql/sql.go

Line 283 in eacfb8a

if f.Type == collaboration.Filter_TYPE_RESOURCE_ID {

as well?

if not track it in a new issue.

[C0rby]

could you add the filter to the sql driver in

Ok let me try.

[C0rby]

@butonic @labkode, I added the filters to the sql share managers. Please have a look at my changes. Also I couldn't test these changes since I don't know how/what to setup for the sql share managers. If you have some documentation or some tips, that would be great.

[lgtm-com]

This pull request introduces 2 alerts when merging 8f0de6e into f2109fc - view on LGTM.com

new alerts:

• 2 for Useless assignment to local variable

[C0rby]

This pull request introduces 2 alerts when merging 8f0de6e into f2109fc - view on LGTM.com

new alerts:

* 2 for Useless assignment to local variable

I resolved this but the comment doesn't disappear and I also can't remove it.

[rhafer]

LGTM. At least I didn't find something obviously wrong here. (Take this with a grain of salt, as I am still pretty new to the code base)

[refs]

Just a pedantic comment from mine, nice PR and nice expected failures cleanup! Thanks!

[C0rby]

The tests fail now because of this PR #2072. Because of that PR rejected shares are not shown in ListReceivedShares responses and there is no way to re-accept or even list a rejected share.

@labkode, how do we want to go forward with this? I think setting the filter in the ocdav layer would be better and then making that behavior configurable. Then an admin could choose if rejected shares should be shown or not.

cc @micbar @butonic

[labkode]

Hi @C0rby that PR should do nothing about accepting or denying shares as we know them today. That PR handles a specific type of share that denies access (DENIAL). That type of share cannot be accepted or rejected by the receiver, the receiver basically can't do anything about it.

The filter set in that PR is to not shown this type of special shares to the receiving user, NOT to filter out reject shares.

Let me know if you need further clarifications.

[C0rby]

The filter set in that PR is to not shown this type of special shares to the receiving user, NOT to filter out reject shares.

I see, then I misunderstood this filter. I will rewrite my code then to reflect the correct behavior.

[C0rby]

@labkode, how do I recognize such deny shares?
Is a share a deny share when DenyGrant is set to true or how can I filter them out in the json and memory manager?

[labkode]

Hi @C0rby, in the SQL manager we set a DenyShare as having permissions=0, so you can do the same on the other drivers, I think is semantically meaningful.

[ishank011]

Hi @C0rby this is really nice! Just left a couple of comments

[C0rby]

Let me just add some unit tests for the new functions and then this PR is good to go. :)

[C0rby]

It's ready now.