Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not display denial shares on Shared-with-me #2072

Merged
merged 2 commits into from
Sep 16, 2021

Conversation

glpatcern
Copy link
Member

Filter the denial shares (permission = 0) out of the Shared-with-me UI view.

Also, denials work regardless whether they are accepted or not, therefore there's no point to expose them.

@glpatcern glpatcern requested a review from labkode as a code owner September 15, 2021 09:49
@update-docs
Copy link

update-docs bot commented Sep 15, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

labkode
labkode previously approved these changes Sep 15, 2021
@labkode
Copy link
Member

labkode commented Sep 16, 2021

@glpatcern I think it just needs rebasing on the latest cs3apis

@glpatcern
Copy link
Member Author

@glpatcern I think it just needs rebasing on the latest cs3apis

Indeed, now I updated all dependencies (via VS Code) and all compiles, however many other dependencies were updated. Do you think it's fine to merge or better stick to the previous versions (except for the cs3apis bindings of course)?

@labkode labkode merged commit 3b9f98f into cs3org:master Sep 16, 2021
glpatcern added a commit to glpatcern/reva that referenced this pull request Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants