-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow full paths #1739
Allow full paths #1739
Conversation
maybe we can use the |
After discussing this with @phil-davis and @individual-it we will introduce a new |
Looking at the test results 81a3b1d actually sooms to work without an additional flag:
Note that to jails users into their home ocis also has to set the ocdav We are working on a owncloud share storage provider that will use an oc10 database to mount shares exactly like in oc10. We need this for migration purposes to run oc10 and ocis in parallel. We will then move towards the spaces api to give clients a more direct way to talk to the correct storage providers. |
@ishank011 let me know if this produces the paths you need for the global namespace. |
@ishank011 @labkode what is that licence check complaining about? AFAICT this can be merged when it has been tested in the global namespace. |
@butonic CI is green! @ishank011 can you please give another pair of eyes? |
@labkode @ishank011 re-check if part of fork |
@butonic can you rebase this one? |
8df1e92
to
c2735ee
Compare
@labkode @ishank011 @micbar rebased and dropped cosmetic changes to the expected failures files |
c2735ee
to
b2a3c71
Compare
2e694b0
to
0efb2c8
Compare
@labkode can you check this out? |
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
0efb2c8
to
55061e1
Compare
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
55061e1
to
e62dba4
Compare
A continuation of #1605, labkode#183 and #1691.
@phil-davis @individual-it I will add the failing tests to the expected failures because there is now a new scenario which is not covered by the oc10 tests. When using a global namespace on top of eos it is possible to do a PROPFIND on
/eos/users/e/
when setting theshare_prefix="/"
,files_namespace="/"
andwebdav_namespace="/"
in the ocs/ocdav config sections.The implentation in this PR allows using global paths, but when a share is not mounted it will leave the internal path, exactly like oc10. It leaks the internal path ... yes, just like oc10 ... so we need to fix it anyway. This will be addressed with the spaces api. For now I'll add the failing test cases to expected failures.
When the spaces API is in place we can clean this up more elegantly because shares will be accessed via the new
/dav/spaces
endpoint.The faling tests expect the shares to be mounted in the users home. But the config is actually setting up a reva instance that jails users into home AND a shares folder, so I think unless an acceptance test contains:
it will fail, which makes sense.