Shares don't have a full file path anymore #2462

kulmann · 2021-09-01T15:01:51Z

Describe the bug

Shares listed in Shared via links or Shared with others don't have a full file path anymore.

Steps to reproduce

Steps to reproduce the behavior:

upload lorem.txt into home
navigate into test-folder
upload lorem.txt test-folder
share both lorem.txt files via quick action for public links
go to shared via links page

Expected behavior

The two shares are two unique entries in the shares list

Actual behavior

The two shares get grouped into one entry in the shares list

Setup

oCIS current master @ 7b1a7b2

Bug analysis

curl 'https://host.docker.internal:9200/ocs/v2.php/apps/files_sharing/api/v1/shares?format=json&reshares=true&include_tags=false&format=json'
inspect response
see that the path and file_target are identical for both shares.
storage_id is different for both shares

I'd expect the path to reflect the parent folders, since this is not shared with me but shared with others. If this is intentionally breaking/changed, we need to do some changes in the web ui. Please tell me how to proceed. :-)

The text was updated successfully, but these errors were encountered:

kulmann · 2021-09-01T15:10:19Z

cs3org/reva#1739 might be related, but from a first glimpse at the code it won't fix the issue.

phil-davis · 2021-09-01T15:36:19Z

Is this a related issue: #2133 ?

kulmann · 2021-09-02T10:08:11Z

Is this a related issue: #2133 ?

yes, looks like it's related

dschmidt · 2022-02-19T01:33:20Z

I just stumbled over this as well. I would like to add that not only the path information is missing, but also the escaping/encoding changed:

http: //host.docker.internal:8080/ocs/v2.php/apps/files_sharing//api/v1/shares?format=json&share_types=3&include_tags=false&format=json

                "path": "\/Photos\/Portugal.jpg",

https: //host.docker.internal:9200/ocs/v2.php/apps/files_sharing//api/v1/shares?format=json&share_types=3&include_tags=false&format=json

                "path": "/Portugal.jpg",

Notice the backslashes.

Is there any news on this issue?

micbar · 2022-02-22T20:26:04Z

@dschmidt @butonic See cs3org/reva#2580 as an approach.

I have some questions to the grouping of shares in oc web.

Is grouping generally desired? (see screenshot below)

It seems to use file_target for grouping outgoing shares which seems wrong.
I would suggest using the fileID for grouping shares together.

Screenshot (wrong attribute but display makes sense)

Response (wrong backend behavior)

{
    "ocs": {
        "meta": {
            "status": "ok",
            "statuscode": 100,
            "message": "OK"
        },
        "data": [
            {
                "id": "NsluGoraTkVJksl",
                "share_type": 3,
                "uid_owner": "marie",
                "displayname_owner": "Marie Curie",
                "additional_info_owner": "[email protected]",
                "permissions": 1,
                "stime": 1645544142,
                "parent": "",
                "expiration": "",
                "token": "IAZWlHamyjDeMWu",
                "uid_file_owner": "marie",
                "displayname_file_owner": "Marie Curie",
                "additional_info_file_owner": "[email protected]",
                "state": 0,
                "path": "/DSC04184.JPG",
                "item_type": "file",
                "mimetype": "image/jpeg",
                "storage_id": "shared::/DSC04184.JPG",
                "storage": 0,
                "item_source": "f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c!b19ea6fc-21a8-4a3a-9346-cc226adf15c7",
                "file_source": "f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c!b19ea6fc-21a8-4a3a-9346-cc226adf15c7",
                "file_parent": "",
                "file_target": "/DSC04184.JPG",
                "share_with_additional_info": "",
                "mail_send": 0,
                "name": "Quick-Action-Link",
                "url": "https://localhost:9200/#/s/IAZWlHamyjDeMWu"
            },
            {
                "id": "uYhDZllDCbtwCKD",
                "share_type": 3,
                "uid_owner": "marie",
                "displayname_owner": "Marie Curie",
                "additional_info_owner": "[email protected]",
                "permissions": 1,
                "stime": 1645544137,
                "parent": "",
                "expiration": "",
                "token": "wqeIEYqVnEueUSy",
                "uid_file_owner": "marie",
                "displayname_file_owner": "Marie Curie",
                "additional_info_file_owner": "[email protected]",
                "state": 0,
                "path": "/ocis-hack-week/DSC04184.JPG",
                "item_type": "file",
                "mimetype": "image/jpeg",
                "storage_id": "shared::/DSC04184.JPG",
                "storage": 0,
                "item_source": "f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c!fcf23326-1906-4bf6-a82c-3e337338965d",
                "file_source": "f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c!fcf23326-1906-4bf6-a82c-3e337338965d",
                "file_parent": "",
                "file_target": "/DSC04184.JPG",
                "share_with_additional_info": "",
                "mail_send": 0,
                "name": "Quick-Action-Link",
                "url": "https://localhost:9200/#/s/wqeIEYqVnEueUSy"
            },
            {
                "id": "e628709b-b913-4914-bc89-1cea060cad86",
                "share_type": 0,
                "uid_owner": "marie",
                "displayname_owner": "Marie Curie",
                "additional_info_owner": "[email protected]",
                "permissions": 1,
                "stime": 1645545111,
                "parent": "",
                "expiration": "",
                "token": "",
                "uid_file_owner": "marie",
                "displayname_file_owner": "Marie Curie",
                "additional_info_file_owner": "[email protected]",
                "state": 0,
                "path": "/ocis-hack-week/DSC04184.JPG",
                "item_type": "file",
                "mimetype": "image/jpeg",
                "storage_id": "shared::/Shares/DSC04184.JPG",
                "storage": 0,
                "item_source": "f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c!fcf23326-1906-4bf6-a82c-3e337338965d",
                "file_source": "f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c!fcf23326-1906-4bf6-a82c-3e337338965d",
                "file_parent": "",
                "file_target": "/Shares/DSC04184.JPG",
                "share_with": "einstein",
                "share_with_displayname": "Albert Einstein",
                "share_with_additional_info": "[email protected]",
                "mail_send": 0,
                "name": ""
            },
            {
                "id": "8be33b64-ee8a-4b0f-9180-099d7acc6b22",
                "share_type": 0,
                "uid_owner": "marie",
                "displayname_owner": "Marie Curie",
                "additional_info_owner": "[email protected]",
                "permissions": 1,
                "stime": 1645546038,
                "parent": "",
                "expiration": "",
                "token": "",
                "uid_file_owner": "marie",
                "displayname_file_owner": "Marie Curie",
                "additional_info_file_owner": "[email protected]",
                "state": 0,
                "path": "/ocis-hack-week",
                "item_type": "folder",
                "mimetype": "httpd/unix-directory",
                "storage_id": "shared::/Shares/ocis-hack-week",
                "storage": 0,
                "item_source": "f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c!14a87e54-22ee-4316-a29a-5e9e3fb5bc7f",
                "file_source": "f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c!14a87e54-22ee-4316-a29a-5e9e3fb5bc7f",
                "file_parent": "",
                "file_target": "/Shares/ocis-hack-week",
                "share_with": "einstein",
                "share_with_displayname": "Albert Einstein",
                "share_with_additional_info": "[email protected]",
                "mail_send": 0,
                "name": ""
            }
        ]
    }
}

It seems to use "file_target": "/Shares/DSC04184.JPG", as grouping attribute. The value makes no sense on the public link share. My pull request changes that.

Response (Right backend behavior)

{
    "ocs": {
        "meta": {
            "status": "ok",
            "statuscode": 100,
            "message": "OK"
        },
        "data": [
            {
                "id": "NsluGoraTkVJksl",
                "share_type": 3,
                "uid_owner": "marie",
                "displayname_owner": "Marie Curie",
                "additional_info_owner": "[email protected]",
                "permissions": 1,
                "stime": 1645544142,
                "parent": "",
                "expiration": "",
                "token": "IAZWlHamyjDeMWu",
                "uid_file_owner": "marie",
                "displayname_file_owner": "Marie Curie",
                "additional_info_file_owner": "[email protected]",
                "state": 0,
                "path": "/DSC04184.JPG",
                "item_type": "file",
                "mimetype": "image/jpeg",
                "storage_id": "shared::/DSC04184.JPG",
                "storage": 0,
                "item_source": "f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c!b19ea6fc-21a8-4a3a-9346-cc226adf15c7",
                "file_source": "f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c!b19ea6fc-21a8-4a3a-9346-cc226adf15c7",
                "file_parent": "",
                "file_target": "/DSC04184.JPG",
                "share_with_additional_info": "",
                "mail_send": 0,
                "name": "Quick-Action-Link",
                "url": "https://localhost:9200/#/s/IAZWlHamyjDeMWu"
            },
            {
                "id": "uYhDZllDCbtwCKD",
                "share_type": 3,
                "uid_owner": "marie",
                "displayname_owner": "Marie Curie",
                "additional_info_owner": "[email protected]",
                "permissions": 1,
                "stime": 1645544137,
                "parent": "",
                "expiration": "",
                "token": "wqeIEYqVnEueUSy",
                "uid_file_owner": "marie",
                "displayname_file_owner": "Marie Curie",
                "additional_info_file_owner": "[email protected]",
                "state": 0,
                "path": "/ocis-hack-week/DSC04184.JPG",
                "item_type": "file",
                "mimetype": "image/jpeg",
                "storage_id": "shared::/DSC04184.JPG",
                "storage": 0,
                "item_source": "f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c!fcf23326-1906-4bf6-a82c-3e337338965d",
                "file_source": "f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c!fcf23326-1906-4bf6-a82c-3e337338965d",
                "file_parent": "",
                "file_target": "/DSC04184.JPG",
                "share_with_additional_info": "",
                "mail_send": 0,
                "name": "Quick-Action-Link",
                "url": "https://localhost:9200/#/s/wqeIEYqVnEueUSy"
            },
            {
                "id": "e628709b-b913-4914-bc89-1cea060cad86",
                "share_type": 0,
                "uid_owner": "marie",
                "displayname_owner": "Marie Curie",
                "additional_info_owner": "[email protected]",
                "permissions": 1,
                "stime": 1645545111,
                "parent": "",
                "expiration": "",
                "token": "",
                "uid_file_owner": "marie",
                "displayname_file_owner": "Marie Curie",
                "additional_info_file_owner": "[email protected]",
                "state": 0,
                "path": "/ocis-hack-week/DSC04184.JPG",
                "item_type": "file",
                "mimetype": "image/jpeg",
                "storage_id": "shared::/Shares/DSC04184.JPG",
                "storage": 0,
                "item_source": "f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c!fcf23326-1906-4bf6-a82c-3e337338965d",
                "file_source": "f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c!fcf23326-1906-4bf6-a82c-3e337338965d",
                "file_parent": "",
                "file_target": "/Shares/DSC04184.JPG",
                "share_with": "einstein",
                "share_with_displayname": "Albert Einstein",
                "share_with_additional_info": "[email protected]",
                "mail_send": 0,
                "name": ""
            },
            {
                "id": "8be33b64-ee8a-4b0f-9180-099d7acc6b22",
                "share_type": 0,
                "uid_owner": "marie",
                "displayname_owner": "Marie Curie",
                "additional_info_owner": "[email protected]",
                "permissions": 1,
                "stime": 1645546038,
                "parent": "",
                "expiration": "",
                "token": "",
                "uid_file_owner": "marie",
                "displayname_file_owner": "Marie Curie",
                "additional_info_file_owner": "[email protected]",
                "state": 0,
                "path": "/ocis-hack-week",
                "item_type": "folder",
                "mimetype": "httpd/unix-directory",
                "storage_id": "shared::/Shares/ocis-hack-week",
                "storage": 0,
                "item_source": "f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c!14a87e54-22ee-4316-a29a-5e9e3fb5bc7f",
                "file_source": "f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c!14a87e54-22ee-4316-a29a-5e9e3fb5bc7f",
                "file_parent": "",
                "file_target": "/Shares/ocis-hack-week",
                "share_with": "einstein",
                "share_with_displayname": "Albert Einstein",
                "share_with_additional_info": "[email protected]",
                "mail_send": 0,
                "name": ""
            }
        ]
    }
}

Bottom line is, it should use "file_source": "f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c!fcf23326-1906-4bf6-a82c-3e337338965d",. as a grouping attribute.

FYI @dschmidt @butonic @kulmann @phil-davis

phil-davis · 2022-02-24T15:46:24Z

The failing acceptance test is now passing after the latest reva code was pulled in with PR #3231

saw-jan · 2022-02-25T05:52:38Z

web test also passed while bumping to latest oCIS https://drone.owncloud.com/owncloud/web/23041/67/15

dschmidt · 2022-03-03T15:29:55Z

Fixed in master (via cs3org/reva#2580) 😍

I'll create a new ticket for the grouping issue in oC Web...

kulmann added the Type:Bug label Sep 1, 2021

kulmann changed the title ~~Shares don~~ Shares don't have a full file path anymore Sep 1, 2021

dragotin added the Priority:p2-high Escalation, on top of current planning, release blocker label Oct 28, 2021

kulmann mentioned this issue Oct 28, 2021

Show path / parent folder to distinguish files owncloud/web#5953

Closed

dschmidt mentioned this issue Feb 19, 2022

[full-ci] Fix several file handling issues for apps owncloud/web#6456

Merged

10 tasks

micbar mentioned this issue Feb 22, 2022

fix public share paths cs3org/reva#2580

Merged

micbar added Status:Needs-Review Needs review from a maintainer Category:Defect Existing functionality is not working as expected OCIS-Fastlane Planned outside of the sprint labels Feb 22, 2022

micbar self-assigned this Feb 22, 2022

dschmidt closed this as completed Mar 3, 2022

dschmidt mentioned this issue Mar 3, 2022

Grouping of shares owncloud/web#6518

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shares don't have a full file path anymore #2462

Shares don't have a full file path anymore #2462

kulmann commented Sep 1, 2021 •

edited

Loading

kulmann commented Sep 1, 2021

phil-davis commented Sep 1, 2021

kulmann commented Sep 2, 2021

dschmidt commented Feb 19, 2022

micbar commented Feb 22, 2022 •

edited

Loading

phil-davis commented Feb 24, 2022

saw-jan commented Feb 25, 2022

dschmidt commented Mar 3, 2022

Shares don't have a full file path anymore #2462

Shares don't have a full file path anymore #2462

Comments

kulmann commented Sep 1, 2021 • edited Loading

Describe the bug

Steps to reproduce

Expected behavior

Actual behavior

Setup

Bug analysis

kulmann commented Sep 1, 2021

phil-davis commented Sep 1, 2021

kulmann commented Sep 2, 2021

dschmidt commented Feb 19, 2022

micbar commented Feb 22, 2022 • edited Loading

Screenshot (wrong attribute but display makes sense)

Response (wrong backend behavior)

Response (Right backend behavior)

phil-davis commented Feb 24, 2022

saw-jan commented Feb 25, 2022

dschmidt commented Mar 3, 2022

kulmann commented Sep 1, 2021 •

edited

Loading

micbar commented Feb 22, 2022 •

edited

Loading