LDAP driver for the groupprovider service #1464
Conversation
|
This pull request introduces 4 alerts when merging 0079b01 into 990ed1b - view on LGTM.com new alerts:
|
| // Default attributes (Active Directory) | ||
| var ldapDefaults = attributes{ | ||
| DN: "dn", | ||
| GID: "objectGUID", // you can fall back to samaccountname but you will run into trouble when group names change. You have been warned. |
There was a problem hiding this comment.
I recommend defaulting to ms-DS-ConsistencyGuid: https://dirteam.com/sander/2017/07/12/azure-ad-connect-objectguid-vs-ms-ds-consistencyguid-part-1/
There was a problem hiding this comment.
or we default to a more posix like schema. for all ... but we need to decide ... which is ldap server we are going to support by default.
There was a problem hiding this comment.
I got this from https://docs.microsoft.com/en-us/azure/active-directory/hybrid/plan-connect-design-concepts#using-ms-ds-consistencyguid-as-sourceanchor.
Use ms-DS-ConsistencyGuid as the sourceAnchor attribute for User objects. ObjectGUID is used for other object types.
But I can change it back to ms-DS-ConsistencyGuid.
| // Default attributes (Active Directory) | ||
| var ldapDefaults = attributes{ | ||
| DN: "dn", | ||
| GID: "objectGUID", // you can fall back to samaccountname but you will run into trouble when group names change. You have been warned. |
There was a problem hiding this comment.
or we default to a more posix like schema. for all ... but we need to decide ... which is ldap server we are going to support by default.
|
This pull request introduces 4 alerts when merging 186848b into 990ed1b - view on LGTM.com new alerts:
|
No description provided.