Skip to content

Commit

Permalink
Fix comment
Browse files Browse the repository at this point in the history
  • Loading branch information
ishank011 committed Feb 9, 2021
1 parent 0079b01 commit 186848b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/group/manager/ldap/ldap.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ type config struct {
type attributes struct {
// DN is the distinguished name in ldap, e.g. `cn=admins,ou=groups,dc=example,dc=org`
DN string `mapstructure:"dn"`
// UID is an immutable group id, see https://docs.microsoft.com/en-us/azure/active-directory/hybrid/plan-connect-design-concepts
// GID is an immutable group id, see https://docs.microsoft.com/en-us/azure/active-directory/hybrid/plan-connect-design-concepts
GID string `mapstructure:"gid"`
// CN is the group name, typically `cn`, `gid` or `samaccountname`
CN string `mapstructure:"cn"`
Expand All @@ -81,7 +81,7 @@ type attributes struct {
// Default attributes (Active Directory)
var ldapDefaults = attributes{
DN: "dn",
GID: "objectGUID", // you can fall back to objectguid or even samaccountname but you will run into trouble when user names change. You have been warned.
GID: "objectGUID", // you can fall back to samaccountname but you will run into trouble when group names change. You have been warned.
CN: "cn",
Mail: "mail",
DisplayName: "displayName",
Expand Down

0 comments on commit 186848b

Please sign in to comment.