Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the .git dir back into the revad image #1413

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

SamuAlfageme
Copy link
Contributor

So we can re-compute the version and sha on the build process

fixes #1406

@update-docs
Copy link

update-docs bot commented Jan 19, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

labkode
labkode previously approved these changes Jan 19, 2021
- So we can pass the version & git sha on the build process.
- Also return 0 on 'revad -version'
@SamuAlfageme SamuAlfageme force-pushed the rm_git_from_dockerignore branch from d27c83a to b38d209 Compare January 19, 2021 16:45
@labkode labkode merged commit 3d28e79 into cs3org:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reva_version="(Unknown)" on latest revad builds
2 participants