Skip to content

Commit

Permalink
Add the .git dir back into the revad image
Browse files Browse the repository at this point in the history
- So we can pass the version & git sha on the build process.
- Also return 0 on 'revad -version'
  • Loading branch information
SamuAlfageme committed Jan 19, 2021
1 parent fcd6626 commit b38d209
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
1 change: 0 additions & 1 deletion .dockerignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
.github
.git
changelog
docs
examples
Expand Down
4 changes: 4 additions & 0 deletions changelog/unreleased/fix-version-string.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Bugfix: re-include the '.git' dir in the Docker images to pass the version tag
and git SHA to the release tool.

https://github.com/cs3org/reva/pull/1413
2 changes: 1 addition & 1 deletion cmd/revad/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ func main() {
func handleVersionFlag() {
if *versionFlag {
fmt.Fprintf(os.Stderr, "%s\n", getVersionString())
os.Exit(1)
os.Exit(0)
}
}

Expand Down

0 comments on commit b38d209

Please sign in to comment.