Minimal Windows support for Process #9047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Int64 is enough to fit the actual underlying values of different platforms (Int32 on Linux, UInt32 on Windows). This will allow to make Process cross-platform without returning a different type to users on different platforms.
…ions Note that most of this change is just extracting parts of process.cr, mostly unchanged. To see that for yourself, make sure to view the patch as `git diff -w HEAD~:src/process.cr src/crystal/system/unix/process.cr` Co-Authored-By: Stephanie Hobbs <[email protected]>
This will be used to call LibC.CreateProcessW from Process.new. Co-Authored-By: Stephanie Hobbs <[email protected]>
Co-Authored-By: Stephanie Hobbs <[email protected]>
This was referenced Apr 11, 2020
Sija
reviewed
Apr 13, 2020
RX14
approved these changes
Apr 13, 2020
Sija
reviewed
Apr 13, 2020
RX14
approved these changes
Apr 13, 2020
straight-shoota
approved these changes
Apr 13, 2020
straight-shoota
added
the
platform:windows
|
Sigh, CI infra failure |
carlhoerberg
pushed a commit
to carlhoerberg/crystal
that referenced
this pull request
Apr 29, 2020
Co-authored-by: Stephanie Hobbs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on RX14@ed14ad5