Add Crystal::System::Process to split out system-specific implementations #9035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Int64 is enough to fit the actual underlying values of different platforms (Int32 on Linux, UInt32 on Windows). This will allow to make Process cross-platform without returning a different type to users on different platforms.
11 tasks
…ions Note that most of this change is just extracting parts of process.cr, mostly unchanged. To see that for yourself, make sure to view the patch as `git diff -w HEAD~:src/process.cr src/crystal/system/unix/process.cr` Co-Authored-By: Stephanie Hobbs <[email protected]>
RX14
approved these changes
Apr 10, 2020
RX14
added
platform:windows
| LibC.pthread_sigmask(LibC::SIG_SETMASK, pointerof(newmask), nil) | ||
| else | ||
| {% unless flag?(:preview_mt) %} | ||
| ::Process.after_fork_child_callbacks.each(&.call) |
There was a problem hiding this comment.
Shouldn't after_fork_child be moved to Crystal::System, too?
There was a problem hiding this comment.
I don't know (like, actually could be conceptually the wrong thing to do) and it's certainly not a requirement to make things work.
straight-shoota
approved these changes
Apr 12, 2020
|
From my side this is ready, only as squash-merge.
|
|
I've already added it to the milestone (which effectively signals it's accepted). Just waiting for CI to finish. |
|
Thanks! |
RX14
approved these changes
Apr 13, 2020
|
Thanks |
carlhoerberg
pushed a commit
to carlhoerberg/crystal
that referenced
this pull request
Apr 29, 2020
…ions (crystal-lang#9035) Note that most of this change is just extracting parts of process.cr, mostly unchanged. To see that for yourself, make sure to view the patch as `git diff -w HEAD~:src/process.cr src/crystal/system/unix/process.cr` Co-authored-by: Stephanie Hobbs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that most of this change is just extracting parts of process.cr, mostly unchanged.
To see that for yourself, make sure to view the patch as
git diff -w master:src/process.cr src/crystal/system/unix/process.crThis is based on RX14@ed14ad5
The Windows counterpart of this
Closes #8536