Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle NaNs when comparing BigFloat against Float #13294

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Handle NaNs when comparing BigFloat against Float #13294

merged 1 commit into from
Apr 18, 2023

Conversation

HertzDevil
Copy link
Contributor

Like #13293, but for BigFloat against Float64::NAN or Float32::NAN.

@HertzDevil HertzDevil added kind:bug A bug in the code. Does not apply to documentation, specs, etc. breaking-change topic:stdlib:numeric labels Apr 6, 2023
@straight-shoota straight-shoota added this to the 1.8.0 milestone Apr 6, 2023
@HertzDevil HertzDevil modified the milestones: 1.8.0, 1.9.0 Apr 6, 2023
@straight-shoota straight-shoota merged commit c23c906 into crystal-lang:master Apr 18, 2023
@HertzDevil HertzDevil deleted the bug/bigfloat-cmp-float branch April 18, 2023 12:21
@HertzDevil HertzDevil mentioned this pull request Apr 18, 2023
Merged
@straight-shoota straight-shoota mentioned this pull request Jul 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:breaking kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:numeric
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@HertzDevil @straight-shoota