Handle NaNs when comparing BigInt
against Float
#13293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparing a
BigInt
against eitherFloat64::NAN
orFloat32::NAN
will raise SIGFPE. This PR fixes that by making#<=>
returnnil
if that is the case.LibGMP.cmp_d
already handles infinities, by the way.Comparisons between
BigInt
s andBigFloat
s aren't affected, as GMP'sBigFloat
does not support NaNs (but MPFR's does).This is a breaking change because previously those return types weren't nilable.