Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatter not merge consecutive but separated comment lines #12909

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Fix formatter not merge consecutive but separated comment lines #12909

merged 1 commit into from
Feb 2, 2023

Conversation

straight-shoota
Copy link
Member

Fixes #12826

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:tools:formatter labels Jan 6, 2023
@straight-shoota straight-shoota self-assigned this Jan 6, 2023
beta-ziliani
beta-ziliani approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@beta-ziliani beta-ziliani added this to the 1.8.0 milestone Feb 1, 2023
@straight-shoota straight-shoota merged commit 23f5147 into crystal-lang:master Feb 2, 2023
@straight-shoota straight-shoota deleted the fix/formatter-comment-merge branch February 2, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beta-ziliani beta-ziliani beta-ziliani approved these changes

Assignees

@straight-shoota straight-shoota

Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:tools:formatter
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

formatter delete blank line between comment.
2 participants
@straight-shoota @beta-ziliani