Fix formatter not merge consecutive but separated comment lines (#12909)

crystal-lang · Feb 2, 2023 · 23f5147 · 23f5147
1 parent 851cd5b
commit 23f5147
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/spec/compiler/formatter/formatter_spec.cr b/spec/compiler/formatter/formatter_spec.cr
@@ -1309,6 +1309,7 @@ describe Crystal::Formatter do
   assert_format "# foo\na = 1 # bar"
   assert_format "#### ###"
   assert_format "#######"
+  assert_format "x\n# foo\n\n# bar"
 
   assert_format "A = 1\nFOO = 2\n\nEX = 3", "A   = 1\nFOO = 2\n\nEX = 3"
   assert_format "FOO = 2\nA = 1", "FOO = 2\nA   = 1"

diff --git a/src/compiler/crystal/tools/formatter.cr b/src/compiler/crystal/tools/formatter.cr
@@ -4778,7 +4778,7 @@ module Crystal
           @wrote_double_newlines = true
         end
 
-        skip_space_or_newline
+        skip_space_or_newline(last: next_comes_end, at_least_one: true)
       end
     end
-Original file line number
+Diff line change
@@ Expand Up / @@ -4778,7 +4778,7 @@ module Crystal @@
               @wrote_double_newlines = true
             end
-            skip_space_or_newline
+            skip_space_or_newline(last: next_comes_end, at_least_one: true)
           end
         end
@@ Expand Down @@