Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use File#flock_exclusive on win32 in compiler #12876

Conversation

straight-shoota
Copy link
Member

Resolve a TODO.
Flock on windows was implemented in #12766

@straight-shoota straight-shoota added kind:feature platform:windows Windows support based on the MSVC toolchain / Win32 API topic:compiler:codegen labels Dec 28, 2022
@straight-shoota straight-shoota self-assigned this Jan 2, 2023
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @straight-shoota 🙏

@straight-shoota straight-shoota added this to the 1.7.0 milestone Jan 3, 2023
@straight-shoota straight-shoota merged commit c945447 into crystal-lang:master Jan 4, 2023
@straight-shoota straight-shoota deleted the feature/enable-flock-win32 branch January 4, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feature platform:windows Windows support based on the MSVC toolchain / Win32 API topic:compiler:codegen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants