Implement flock_* for Win32
#12766
Merged
Implement flock_* for Win32
#12766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
added
kind:feature
platform:windows
|
Does this obsolete #12681? |
|
Yes, this is a superior fiber-aware implementation. But I see there are some parts in that which we should keep. |
Comment on lines
+48
to
+49
| LOCKFILE_FAIL_IMMEDIATELY = DWORD.new(0x00000001) | ||
| LOCKFILE_EXCLUSIVE_LOCK = DWORD.new(0x00000002) |
There was a problem hiding this comment.
This is not really needed, right?
Suggested change
| LOCKFILE_FAIL_IMMEDIATELY = DWORD.new(0x00000001) | |
| LOCKFILE_EXCLUSIVE_LOCK = DWORD.new(0x00000002) | |
| LOCKFILE_FAIL_IMMEDIATELY = 0x00000001 | |
| LOCKFILE_EXCLUSIVE_LOCK = 0x00000002 |
There was a problem hiding this comment.
Not necessarily, but that's only because DWORD is equivalent to the default integer type Int32.
Prior evidence:
crystal/src/lib_c/x86_64-windows-msvc/c/fileapi.cr
Lines 10 to 13 in 022e1f9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation is analog to #12728 just for the Win32 API.
Closes #12681