Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable multithreading specs on Windows CI #12843

Merged

Conversation

HertzDevil
Copy link
Contributor

Those specs were explicitly disabled in #12282, and #11647 didn't add them back. This patch does that.

Let's see if CI fails again... (once again I could not reproduce the crash locally)

@HertzDevil HertzDevil added topic:infrastructure platform:windows Windows support based on the MSVC toolchain / Win32 API kind:specs topic:multithreading labels Dec 15, 2022
Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@straight-shoota straight-shoota added this to the 1.7.0 milestone Dec 15, 2022
@straight-shoota straight-shoota merged commit 7b26311 into crystal-lang:master Dec 15, 2022
@HertzDevil HertzDevil deleted the spec/windows-threads branch December 16, 2022 08:44
carlhoerberg pushed a commit to carlhoerberg/crystal that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:specs platform:windows Windows support based on the MSVC toolchain / Win32 API topic:infrastructure topic:multithreading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants