-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove spec/win32_std_spec.cr
#12282
Remove spec/win32_std_spec.cr
#12282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @HertzDevil 🙏
👀
This failing spec is already activated before this PR, so it's probably not a new addition. |
I have been getting that error intermittently on local builds as well, plus this one from the first CI run:
This blocks the whole spec. I have no idea if #12281 caused these errors or the root cause is simply an incomplete event loop implementation. I got one CI run green. |
This looks very much like a flaw in the event loop. |
The three new examples introduced in this PR are I am wondering if the failures can also be reproduced by simply rearranging the |
CI is green consistently, so I think this should be good to merge. |
With just 8 out of 259 spec files failing to compile on Windows, there is no longer a dire need to keep a list of the spec files that do build. This PR makes the remaining specs use
skip_file
instead, similar to the Unix domain socket ones. It looks like this enables 3 new examples somewhere.The script that generates
spec/win32_std_spec.cr
remains intact in case we want to reuse it for some other completely new system.