Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WASM] Add missing __powisf2 and __powidf2 compiler-rt functions #12569

Merged
merged 4 commits into from
Oct 23, 2022
+212 −1
Merged

[WASM] Add missing __powisf2 and __powidf2 compiler-rt functions #12569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
256e254
feat: add missing __powisf2 and __powidf2 on wasm32
lbguilherme Oct 5, 2022
6e08cb6
Merge branch 'master' into wasm32/__powisf2-and-__powidf2
lbguilherme Oct 5, 2022
07dc008
fix: crystal tool format
lbguilherme Oct 5, 2022
9e0fab0
Merge branch 'master' into wasm32/__powisf2-and-__powidf2
straight-shoota Oct 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 94 additions & 0 deletions spec/std/crystal/compiler_rt/powidf2_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
require "spec"
require "crystal/compiler_rt/pow"

# Ported from https://github.com/llvm/llvm-project/blob/2e9df860468425645dcd1b241c5dbf76c072e314/compiler-rt/test/builtins/Unit/powidf2_test.c

it ".__powidf2" do
__powidf2(0, 0).should eq 1
__powidf2(1, 0).should eq 1
__powidf2(1.5, 0).should eq 1
__powidf2(2, 0).should eq 1
__powidf2(Float64::INFINITY, 0).should eq 1
__powidf2(-0.0, 0).should eq 1
__powidf2(-1, 0).should eq 1
__powidf2(-1.5, 0).should eq 1
__powidf2(-2, 0).should eq 1
__powidf2(-Float64::INFINITY, 0).should eq 1
__powidf2(0, 1).should eq 0
__powidf2(0, 2).should eq 0
__powidf2(0, 3).should eq 0
__powidf2(0, 4).should eq 0
__powidf2(0, Int32::MAX - 1).should eq 0
__powidf2(0, Int32::MAX).should eq 0
__powidf2(-0.0, 1).should eq -0.0
__powidf2(-0.0, 2).should eq 0
__powidf2(-0.0, 3).should eq -0.0
__powidf2(-0.0, 4).should eq 0
__powidf2(-0.0, Int32::MAX - 1).should eq 0
__powidf2(-0.0, Int32::MAX).should eq -0.0
__powidf2(1, 1).should eq 1
__powidf2(1, 2).should eq 1
__powidf2(1, 3).should eq 1
__powidf2(1, 4).should eq 1
__powidf2(1, Int32::MAX - 1).should eq 1
__powidf2(1, Int32::MAX).should eq 1
__powidf2(Float64::INFINITY, 1).should eq Float64::INFINITY
__powidf2(Float64::INFINITY, 2).should eq Float64::INFINITY
__powidf2(Float64::INFINITY, 3).should eq Float64::INFINITY
__powidf2(Float64::INFINITY, 4).should eq Float64::INFINITY
__powidf2(Float64::INFINITY, Int32::MAX - 1).should eq Float64::INFINITY
__powidf2(Float64::INFINITY, Int32::MAX).should eq Float64::INFINITY
__powidf2(-Float64::INFINITY, 1).should eq -Float64::INFINITY
__powidf2(-Float64::INFINITY, 2).should eq Float64::INFINITY
__powidf2(-Float64::INFINITY, 3).should eq -Float64::INFINITY
__powidf2(-Float64::INFINITY, 4).should eq Float64::INFINITY
__powidf2(-Float64::INFINITY, Int32::MAX - 1).should eq Float64::INFINITY
__powidf2(-Float64::INFINITY, Int32::MAX).should eq -Float64::INFINITY
__powidf2(0, -1).should eq Float64::INFINITY
__powidf2(0, -2).should eq Float64::INFINITY
__powidf2(0, -3).should eq Float64::INFINITY
__powidf2(0, -4).should eq Float64::INFINITY
__powidf2(0, Int32::MIN + 2).should eq Float64::INFINITY
__powidf2(0, Int32::MIN + 1).should eq Float64::INFINITY
__powidf2(0, Int32::MIN).should eq Float64::INFINITY
__powidf2(-0.0, -1).should eq -Float64::INFINITY
__powidf2(-0.0, -2).should eq Float64::INFINITY
__powidf2(-0.0, -3).should eq -Float64::INFINITY
__powidf2(-0.0, -4).should eq Float64::INFINITY
__powidf2(-0.0, Int32::MIN + 2).should eq Float64::INFINITY
__powidf2(-0.0, Int32::MIN + 1).should eq -Float64::INFINITY
__powidf2(-0.0, Int32::MIN).should eq Float64::INFINITY
__powidf2(1, -1).should eq 1
__powidf2(1, -2).should eq 1
__powidf2(1, -3).should eq 1
__powidf2(1, -4).should eq 1
__powidf2(1, Int32::MIN + 2).should eq 1
__powidf2(1, Int32::MIN + 1).should eq 1
__powidf2(1, Int32::MIN).should eq 1
__powidf2(Float64::INFINITY, -1).should eq 0
__powidf2(Float64::INFINITY, -2).should eq 0
__powidf2(Float64::INFINITY, -3).should eq 0
__powidf2(Float64::INFINITY, -4).should eq 0
__powidf2(Float64::INFINITY, Int32::MIN + 2).should eq 0
__powidf2(Float64::INFINITY, Int32::MIN + 1).should eq 0
__powidf2(Float64::INFINITY, Int32::MIN).should eq 0
__powidf2(-Float64::INFINITY, -1).should eq -0.0
__powidf2(-Float64::INFINITY, -2).should eq 0
__powidf2(-Float64::INFINITY, -3).should eq -0.0
__powidf2(-Float64::INFINITY, -4).should eq 0
__powidf2(-Float64::INFINITY, Int32::MIN + 2).should eq 0
__powidf2(-Float64::INFINITY, Int32::MIN + 1).should eq -0.0
__powidf2(-Float64::INFINITY, Int32::MIN).should eq 0
__powidf2(2, 10).should eq 1024.0
__powidf2(-2, 10).should eq 1024.0
__powidf2(2, -10).should eq 1/1024.0
__powidf2(-2, -10).should eq 1/1024.0
__powidf2(2, 19).should eq 524288.0
__powidf2(-2, 19).should eq -524288.0
__powidf2(2, -19).should eq 1/524288.0
__powidf2(-2, -19).should eq -1/524288.0
__powidf2(2, 31).should eq 2147483648.0
__powidf2(-2, 31).should eq -2147483648.0
__powidf2(2, -31).should eq 1/2147483648.0
__powidf2(-2, -31).should eq -1/2147483648.0
end
94 changes: 94 additions & 0 deletions spec/std/crystal/compiler_rt/powisf2_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
require "spec"
require "crystal/compiler_rt/pow"

# Ported from https://github.com/llvm/llvm-project/blob/2e9df860468425645dcd1b241c5dbf76c072e314/compiler-rt/test/builtins/Unit/powisf2_test.c

it ".__powisf2" do
__powisf2(0, 0).should eq 1
__powisf2(1, 0).should eq 1
__powisf2(1.5, 0).should eq 1
__powisf2(2, 0).should eq 1
__powisf2(Float32::INFINITY, 0).should eq 1
__powisf2(-0.0, 0).should eq 1
__powisf2(-1, 0).should eq 1
__powisf2(-1.5, 0).should eq 1
__powisf2(-2, 0).should eq 1
__powisf2(-Float32::INFINITY, 0).should eq 1
__powisf2(0, 1).should eq 0
__powisf2(0, 2).should eq 0
__powisf2(0, 3).should eq 0
__powisf2(0, 4).should eq 0
__powisf2(0, Int32::MAX - 1).should eq 0
__powisf2(0, Int32::MAX).should eq 0
__powisf2(-0.0, 1).should eq -0.0
__powisf2(-0.0, 2).should eq 0
__powisf2(-0.0, 3).should eq -0.0
__powisf2(-0.0, 4).should eq 0
__powisf2(-0.0, Int32::MAX - 1).should eq 0
__powisf2(-0.0, Int32::MAX).should eq -0.0
__powisf2(1, 1).should eq 1
__powisf2(1, 2).should eq 1
__powisf2(1, 3).should eq 1
__powisf2(1, 4).should eq 1
__powisf2(1, Int32::MAX - 1).should eq 1
__powisf2(1, Int32::MAX).should eq 1
__powisf2(Float32::INFINITY, 1).should eq Float32::INFINITY
__powisf2(Float32::INFINITY, 2).should eq Float32::INFINITY
__powisf2(Float32::INFINITY, 3).should eq Float32::INFINITY
__powisf2(Float32::INFINITY, 4).should eq Float32::INFINITY
__powisf2(Float32::INFINITY, Int32::MAX - 1).should eq Float32::INFINITY
__powisf2(Float32::INFINITY, Int32::MAX).should eq Float32::INFINITY
__powisf2(-Float32::INFINITY, 1).should eq -Float32::INFINITY
__powisf2(-Float32::INFINITY, 2).should eq Float32::INFINITY
__powisf2(-Float32::INFINITY, 3).should eq -Float32::INFINITY
__powisf2(-Float32::INFINITY, 4).should eq Float32::INFINITY
__powisf2(-Float32::INFINITY, Int32::MAX - 1).should eq Float32::INFINITY
__powisf2(-Float32::INFINITY, Int32::MAX).should eq -Float32::INFINITY
__powisf2(0, -1).should eq Float32::INFINITY
__powisf2(0, -2).should eq Float32::INFINITY
__powisf2(0, -3).should eq Float32::INFINITY
__powisf2(0, -4).should eq Float32::INFINITY
__powisf2(0, Int32::MIN + 2).should eq Float32::INFINITY
__powisf2(0, Int32::MIN + 1).should eq Float32::INFINITY
__powisf2(0, Int32::MIN).should eq Float32::INFINITY
__powisf2(-0.0, -1).should eq -Float32::INFINITY
__powisf2(-0.0, -2).should eq Float32::INFINITY
__powisf2(-0.0, -3).should eq -Float32::INFINITY
__powisf2(-0.0, -4).should eq Float32::INFINITY
__powisf2(-0.0, Int32::MIN + 2).should eq Float32::INFINITY
__powisf2(-0.0, Int32::MIN + 1).should eq -Float32::INFINITY
__powisf2(-0.0, Int32::MIN).should eq Float32::INFINITY
__powisf2(1, -1).should eq 1
__powisf2(1, -2).should eq 1
__powisf2(1, -3).should eq 1
__powisf2(1, -4).should eq 1
__powisf2(1, Int32::MIN + 2).should eq 1
__powisf2(1, Int32::MIN + 1).should eq 1
__powisf2(1, Int32::MIN).should eq 1
__powisf2(Float32::INFINITY, -1).should eq 0
__powisf2(Float32::INFINITY, -2).should eq 0
__powisf2(Float32::INFINITY, -3).should eq 0
__powisf2(Float32::INFINITY, -4).should eq 0
__powisf2(Float32::INFINITY, Int32::MIN + 2).should eq 0
__powisf2(Float32::INFINITY, Int32::MIN + 1).should eq 0
__powisf2(Float32::INFINITY, Int32::MIN).should eq 0
__powisf2(-Float32::INFINITY, -1).should eq -0.0
__powisf2(-Float32::INFINITY, -2).should eq 0
__powisf2(-Float32::INFINITY, -3).should eq -0.0
__powisf2(-Float32::INFINITY, -4).should eq 0
__powisf2(-Float32::INFINITY, Int32::MIN + 2).should eq 0
__powisf2(-Float32::INFINITY, Int32::MIN + 1).should eq -0.0
__powisf2(-Float32::INFINITY, Int32::MIN).should eq 0
__powisf2(2, 10).should eq 1024.0
__powisf2(-2, 10).should eq 1024.0
__powisf2(2, -10).should eq 1/1024.0
__powisf2(-2, -10).should eq 1/1024.0
__powisf2(2, 19).should eq 524288.0
__powisf2(-2, 19).should eq -524288.0
__powisf2(2, -19).should eq 1/524288.0
__powisf2(-2, -19).should eq -1/524288.0
__powisf2(2, 31).should eq 2147483648.0
__powisf2(-2, 31).should eq -2147483648.0
__powisf2(2, -31).should eq 1/2147483648.0
__powisf2(-2, -31).should eq -1/2147483648.0
end
5 changes: 4 additions & 1 deletion src/crystal/compiler_rt.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,11 @@ require "./compiler_rt/divmod128.cr"
{% end %}

{% if flag?(:wasm32) %}
# __ashlti3, __ashrti3 and __lshrti3 were only missing on wasm32
# __ashlti3, __ashrti3 and __lshrti3 are missing on wasm32
require "./compiler_rt/shift.cr"

# __powisf2 and __powidf2 are missing on wasm32
require "./compiler_rt/pow.cr"
{% end %}

{% if flag?(:win32) && flag?(:bits64) %}
Expand Down
20 changes: 20 additions & 0 deletions src/crystal/compiler_rt/pow.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
private macro __pow_impl(name, one, float_type)
# :nodoc:
# Ported from https://github.com/llvm/llvm-project/blob/2e9df860468425645dcd1b241c5dbf76c072e314/compiler-rt/lib/builtins
fun {{name}}(a : {{float_type}}, b : Int32) : {{float_type}}
recip = b < 0
r = {{one}}

loop do
r *= a if b & 1 != 0
b = b.unsafe_div 2
break if b == 0
a *= a
end

recip ? 1 / r : r
end
end

__pow_impl(__powisf2, 1f32, Float32)
__pow_impl(__powidf2, 1f64, Float64)