Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WASM] Add missing __powisf2 and __powidf2 compiler-rt functions #12569

Merged
merged 4 commits into from
Oct 23, 2022
Merged

[WASM] Add missing __powisf2 and __powidf2 compiler-rt functions #12569

merged 4 commits into from
Oct 23, 2022

Conversation

lbguilherme
Copy link
Contributor

Functions __powisf2 and __powidf2 from compiler-rt are called from the wasm32 codegen and must be provided. This happens whenever float exponentiation is used.

wasm-ld: error: F-loat64.wasm: undefined symbol: __powidf2

Implementation source:

@lbguilherme lbguilherme mentioned this pull request Oct 6, 2022
Merged
@lbguilherme
Copy link
Contributor Author

CI failure is unrelated.

@HertzDevil HertzDevil added this to the 1.7.0 milestone Oct 9, 2022
@straight-shoota straight-shoota changed the title [WASM] add missing __powisf2 and __powidf2 compiler-rt functions [WASM] Add missing __powisf2 and __powidf2 compiler-rt functions Oct 23, 2022
@straight-shoota straight-shoota merged commit e6de9e3 into crystal-lang:master Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HertzDevil HertzDevil HertzDevil approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:feature platform:wasm topic:stdlib:numeric
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lbguilherme @straight-shoota @HertzDevil