Add HTTP::Server::Response#redirect
#12526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
asterite
approved these changes
Sep 26, 2022
lbguilherme
pushed a commit
to lbguilherme/crystal
that referenced
this pull request
Oct 24, 2022
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-issue of #10412 which was merged in a broken state and subsequently reverted.
This is a proposal for a method
HTTP::Server::Response#redirectwhich offers a simple way to issue redirects from HTTP server handlers.respond_with_statusis a similar convenience method.Redirects are pretty common and a helper for this would be very useful. In fact, there's already an implementation in
StaticFileHandler. Most web frameworks probably provide a helper for this, too (example: kemal). But it would be nice to have this at hand for plain server handlers. And simple implementations like kemal's could be based on or replaced by the stdlib implementation.Resolves #12490