Add HTTP::Server::Response#redirect
#10412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
reviewed
Feb 18, 2021
Sija
reviewed
Feb 23, 2021
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
asterite
reviewed
Sep 18, 2022
Sija
reviewed
Sep 21, 2022
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
HertzDevil
reviewed
Sep 22, 2022
HertzDevil
approved these changes
Sep 22, 2022
asterite
reviewed
Sep 22, 2022
|
Ooops, I mistakenly merged this despite CI errors. 🙈 Sorry. I'll send a fixup right away. |
|
Or scrap that, I'll just revert it for now. |
straight-shoota
added a commit
that referenced
this pull request
Sep 24, 2022
This reverts commit abff4f7.
HertzDevil
pushed a commit
that referenced
this pull request
Sep 25, 2022
This reverts commit abff4f7.
HertzDevil
reviewed
Sep 25, 2022
|
|
||
| url = URI.encode_path(url.to_s) | ||
| context.response.headers.add "Location", url | ||
| context.response.redirect url |
There was a problem hiding this comment.
Apparently this is where the Path comes from. It is hard to say whether this justifies the use of unrestricted Paths in the public API.
There was a problem hiding this comment.
At least I now remember the reason for adding Path to the restriction 😅
But I think I'd still stick to the plan and just call to_s here.
straight-shoota
added
the
status:reverted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for a method
HTTP::Server::Response#redirectwhich offers a simple way to issue redirects from HTTP server handlers.respond_with_statusis a similar convenience method.Redirects are pretty common and a helper for this would be very useful. In fact, there's already an implementation in
StaticFileHandler. Most web frameworks probably provide a helper for this, too (example: kemal). But it would be nice to have this at hand for plain server handlers. And simple implementations like kemal's could be based on or replaced by the stdlib implementation.