Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling #12040

Merged
merged 52 commits into from
May 23, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
07a39ed
spelling: abcdefghijklmnopqrstuvwxyz
jsoref May 1, 2022
2d21aeb
spelling: address
jsoref May 1, 2022
a5c32f5
spelling: all
jsoref May 1, 2022
f6df735
spelling: allocation
jsoref May 1, 2022
c7f1682
spelling: and
jsoref May 2, 2022
1df649d
spelling: another
jsoref May 1, 2022
f64ee65
spelling: appropriate
jsoref May 1, 2022
99d6dab
spelling: assigning
jsoref May 1, 2022
db98566
spelling: can
jsoref May 1, 2022
51ece83
spelling: catch_ret
jsoref May 1, 2022
d7bce1c
spelling: class
jsoref May 1, 2022
4e69a51
spelling: content
jsoref May 1, 2022
ae9d9b2
spelling: conversion
jsoref May 1, 2022
9e8026e
spelling: corresponds
jsoref May 1, 2022
bc6251c
spelling: daylight
jsoref May 1, 2022
4855823
spelling: decimal
jsoref May 1, 2022
fda4f64
spelling: emojis
jsoref May 1, 2022
136b9b2
spelling: enabled
jsoref May 1, 2022
f273f49
spelling: entity
jsoref May 1, 2022
755f277
spelling: ephemeral
jsoref May 1, 2022
b0a655a
spelling: epilogue
jsoref May 1, 2022
7388933
spelling: established
jsoref May 1, 2022
3ea1f2f
spelling: expanded
jsoref May 1, 2022
8fa5eb2
spelling: functionality
jsoref May 1, 2022
1062226
spelling: github
jsoref May 3, 2022
744c0f2
spelling: gitlab
jsoref May 1, 2022
9371ab5
spelling: gnurefalt
jsoref May 1, 2022
9313062
spelling: hexadecimal
jsoref May 1, 2022
e41d2dd
spelling: html
jsoref May 1, 2022
6e9febf
spelling: if
jsoref May 3, 2022
1c90041
spelling: inspired
jsoref May 1, 2022
583ea6a
spelling: interpreted
jsoref May 1, 2022
a5722a4
spelling: interpreter
jsoref May 1, 2022
8f91153
spelling: intrinsic
jsoref May 1, 2022
fa6e32c
spelling: nonexistent
jsoref May 1, 2022
50a4fbc
spelling: opening
jsoref May 1, 2022
c2028ad
spelling: overriding
jsoref May 1, 2022
9546ed4
spelling: potentially
jsoref May 1, 2022
650b123
spelling: purposes
jsoref May 1, 2022
c313e73
spelling: reachable
jsoref May 1, 2022
3dc95d4
spelling: regarding
jsoref May 1, 2022
33d48ef
spelling: regex
jsoref May 1, 2022
729060e
spelling: request
jsoref May 1, 2022
a6254fc
spelling: room
jsoref May 1, 2022
031ef7e
spelling: several
jsoref May 1, 2022
8ad77d8
spelling: strict
jsoref May 1, 2022
69b4bc6
spelling: support
jsoref May 1, 2022
ac8ed50
spelling: switch
jsoref May 1, 2022
a11c361
spelling: timeout
jsoref May 1, 2022
92ab021
spelling: uniquely
jsoref May 1, 2022
c311d78
spelling: with
jsoref May 1, 2022
a9b9cc2
spelling: workaround
jsoref May 1, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@
- `crystal i`, a Crystal interpreter ([#11159](https://github.com/crystal-lang/crystal/pull/11159), thanks @asterite)
- Implement FFI bindings ([#11475](https://github.com/crystal-lang/crystal/pull/11475), thanks @straight-shoota)
- Add `Crystal::Loader` ([#11434](https://github.com/crystal-lang/crystal/pull/11434), [#11662](https://github.com/crystal-lang/crystal/pull/11662), thanks @straight-shoota, @HertzDevil)
- Mark `bswap32` instrinsic with interpreter primitive annotation ([#11582](https://github.com/crystal-lang/crystal/pull/11582), thanks @rymiel)
- Mark `bswap32` intrinsic with interpreter primitive annotation ([#11582](https://github.com/crystal-lang/crystal/pull/11582), thanks @rymiel)
- Split interpreter specs into separate files ([#11578](https://github.com/crystal-lang/crystal/pull/11578), thanks @straight-shoota)
- Workaround for GC issues in interpreter specs ([#11634](https://github.com/crystal-lang/crystal/pull/11634), thanks @straight-shoota)

Expand Down Expand Up @@ -395,7 +395,7 @@
- Add more `check_headers` to `HTTP::Server::Response` ([#11253](https://github.com/crystal-lang/crystal/pull/11253), thanks @straight-shoota)
- Enable `LogHandler` address for win32 ([#11465](https://github.com/crystal-lang/crystal/pull/11465), thanks @straight-shoota)
- Enable two specs to run on all platforms ([#11467](https://github.com/crystal-lang/crystal/pull/11467), thanks @straight-shoota)
- `TCPServer`: explain how to get an ephermal port ([#11407](https://github.com/crystal-lang/crystal/pull/11407), thanks @rdp)
- `TCPServer`: explain how to get an ephemeral port ([#11407](https://github.com/crystal-lang/crystal/pull/11407), thanks @rdp)
- Fix `HTTP::Server::Response#close` when replaced output syncs close ([#11631](https://github.com/crystal-lang/crystal/pull/11631), thanks @straight-shoota)

### Numeric
Expand Down Expand Up @@ -815,7 +815,7 @@
- Refactor `Socket::Addrinfo::Error` based on `os_error `. ([#10761](https://github.com/crystal-lang/crystal/pull/10761), thanks @straight-shoota)
- Add `WinError.wsa_value` and specs for `WinError`. ([#10762](https://github.com/crystal-lang/crystal/pull/10762), thanks @straight-shoota)
- Add specs for `Errno`. ([#10763](https://github.com/crystal-lang/crystal/pull/10763), thanks @straight-shoota)
- Refactor: Move win32 libc bindings from `winbase.cr` to approriate files. ([#10771](https://github.com/crystal-lang/crystal/pull/10771), thanks @straight-shoota)
- Refactor: Move win32 libc bindings from `winbase.cr` to appropriate files. ([#10771](https://github.com/crystal-lang/crystal/pull/10771), thanks @straight-shoota)
- Refactor: Change protocol socket fd to `Socket::Handle`. ([#10772](https://github.com/crystal-lang/crystal/pull/10772), thanks @straight-shoota)
- Fix `Socket::Connect` error in addrinfo inherit `os_error`. ([#10782](https://github.com/crystal-lang/crystal/pull/10782), thanks @straight-shoota)
- Reorganize some win32 libc bindings ([#10776](https://github.com/crystal-lang/crystal/pull/10776), thanks @straight-shoota)
Expand Down Expand Up @@ -844,7 +844,7 @@
- Fix handling of arithmetic overflow in `BigDecimal#div`. ([#10628](https://github.com/crystal-lang/crystal/pull/10628), thanks @kellydanma)
- Clarify behaviour of unsafe `Float`-to-number conversions. ([#10631](https://github.com/crystal-lang/crystal/pull/10631), thanks @HertzDevil)
- Fix return type restriction for `Number#humanize` overload. ([#10633](https://github.com/crystal-lang/crystal/pull/10633), thanks @HertzDevil)
- Fix `printf` float with with many digits. ([#10719](https://github.com/crystal-lang/crystal/pull/10719), thanks @straight-shoota)
- Fix `printf` float with many digits. ([#10719](https://github.com/crystal-lang/crystal/pull/10719), thanks @straight-shoota)
- Add `BigDecimal`'s missing rounding modes. ([#10798](https://github.com/crystal-lang/crystal/pull/10798), thanks @HertzDevil)
- Add support for using big rational `#**` with unsigned ints. ([#10887](https://github.com/crystal-lang/crystal/pull/10887), thanks @stakach)
- Add overflow detection to `BigFloat#to_i64` and `#to_u64`. ([#10630](https://github.com/crystal-lang/crystal/pull/10630), thanks @HertzDevil)
Expand Down Expand Up @@ -1389,7 +1389,7 @@
- Run side effects for class var with constant initializer. ([#10010](https://github.com/crystal-lang/crystal/pull/10010), thanks @asterite)
- Fix `VaList` and disable `va_arg` for AArch64. ([#9422](https://github.com/crystal-lang/crystal/pull/9422), thanks @jhass)
- Fix cache corrupted when compilation is cancelled. ([#9558](https://github.com/crystal-lang/crystal/pull/9558), thanks @waj)
- Consider `select` as an openning keyword in macros. ([#9624](https://github.com/crystal-lang/crystal/pull/9624), thanks @asterite)
- Consider `select` as an opening keyword in macros. ([#9624](https://github.com/crystal-lang/crystal/pull/9624), thanks @asterite)
- Use function attribute `frame-pointer`. ([#9361](https://github.com/crystal-lang/crystal/pull/9361), thanks @kubo39)
- Make missing `__crystal_raise_overflow` error more clear. ([#9686](https://github.com/crystal-lang/crystal/pull/9686), thanks @3n-k1)
- Forbid calls with both block arg and block. ([#10026](https://github.com/crystal-lang/crystal/pull/10026), thanks @HertzDevil)
Expand Down Expand Up @@ -3643,7 +3643,7 @@
## Misc
- The platform-specific parts of `File` and `IO::FileDescriptor` were moved to `Crystal::System`, as part of preparation for the Windows port. ([#5333](https://github.com/crystal-lang/crystal/pull/5333), [#5553](https://github.com/crystal-lang/crystal/pull/5553), [#5622](https://github.com/crystal-lang/crystal/pull/5622) thanks @RX14)
- The platform-specific parts of `Dir` were moved to `Crystal::System`, as part of preparation for the Windows port. ([#5447](https://github.com/crystal-lang/crystal/pull/5447), thanks @RX14)
- Incremental contributions regaring Windows support. ([#5422](https://github.com/crystal-lang/crystal/pull/5422), [#5524](https://github.com/crystal-lang/crystal/pull/5524), [#5533](https://github.com/crystal-lang/crystal/pull/5533), [#5538](https://github.com/crystal-lang/crystal/pull/5538), [#5539](https://github.com/crystal-lang/crystal/pull/5539), [#5580](https://github.com/crystal-lang/crystal/pull/5580), [#5947](https://github.com/crystal-lang/crystal/pull/5947) thanks @RX14 and @straight-shoota)
- Incremental contributions regarding Windows support. ([#5422](https://github.com/crystal-lang/crystal/pull/5422), [#5524](https://github.com/crystal-lang/crystal/pull/5524), [#5533](https://github.com/crystal-lang/crystal/pull/5533), [#5538](https://github.com/crystal-lang/crystal/pull/5538), [#5539](https://github.com/crystal-lang/crystal/pull/5539), [#5580](https://github.com/crystal-lang/crystal/pull/5580), [#5947](https://github.com/crystal-lang/crystal/pull/5947) thanks @RX14 and @straight-shoota)
- The build on OpenBSD was fixed. ([#5387](https://github.com/crystal-lang/crystal/pull/5387), thanks @wmoxam)
- Add support for FreeBSD 12 (64-bit inodes). ([#5199](https://github.com/crystal-lang/crystal/pull/5199), thanks @myfreeweb)
- Scripts and makefiles now depend on `sh` instead of `bash` for greater portability. ([#5468](https://github.com/crystal-lang/crystal/pull/5468), thanks @j8r)
Expand Down Expand Up @@ -3684,7 +3684,7 @@
- Add custom extension support to `Tempfile`. ([#5264](https://github.com/crystal-lang/crystal/issues/5264), thanks @jreinert)
- Add `reduce` method to `TupleLiteral` and `ArrayLiteral` when using macros. ([#5294](https://github.com/crystal-lang/crystal/issues/5294), thanks @javanut13)
- Export a JSON representation of the documentation in the generated output. ([#4746](https://github.com/crystal-lang/crystal/issues/4746) and [#5228](https://github.com/crystal-lang/crystal/issues/5228), thanks @straight-shoota)
- Make `gc/none` garbage collection compile again and allow it to be enbled using `-Dgc_none` compiler flag. ([#5314](https://github.com/crystal-lang/crystal/issues/5314), thanks @ysbaddaden)
- Make `gc/none` garbage collection compile again and allow it to be enabled using `-Dgc_none` compiler flag. ([#5314](https://github.com/crystal-lang/crystal/issues/5314), thanks @ysbaddaden)

## Standard library bugs fixed
- Make `String#[]` unable to read out-of-bounds when the string ends in a unicode character. ([#5257](https://github.com/crystal-lang/crystal/issues/5257), thanks @Papierkorb)
Expand Down Expand Up @@ -4305,7 +4305,7 @@
* Added `String#insert`
* Added `Time::EpochConverter` and `Time::EpochMillisConverter`
* Added `%s` (unix epoch) directive to `Time::Format`
* `Time` now honours Dayling Saving and `ENV["TZ"]`
* `Time` now honours Daylight Saving and `ENV["TZ"]`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notable change.

Some projects don't like retroactively changing changelogs, if this is one, just let me know.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer fixing such typos in the changelog. Thanks!

* Added `HTTP::Server::Response#cookies` (thanks @jhass)
* Added `Array#bsearch`, `Array#bsearch_index` and `Range#bsearch` (thanks @MakeNowJust)
* Added `Range#reverse_each` iterator (thanks @omninonsense)
Expand Down Expand Up @@ -4398,7 +4398,7 @@
* `HTTP::Client`: added a constructor with an `URI` argument (thanks @plukevdh)
* `String`: `sub` and `gsub` now understand backreferences (thanks @bjmllr)
* `Random`: added `Random#rand(Float64)` and `Random#rand(Range(Float, Float))` (thanks @AlexWayfer)
* `HTML`: `HTLM.escape` includes more characters (thanks @Ryuuzakis)
* `HTML`: `HTML.escape` includes more characters (thanks @Ryuuzakis)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notable

* Added `TypeNode.class` method in macros (thanks @waterlink)
* `run` inside macros now also work with absolute paths (useful when used with `__DIR__`)
* Added docs for `Math` and `StaticArray` (thanks @Zavydiel, @HeleneMyr)
Expand Down Expand Up @@ -4473,7 +4473,7 @@
* Added `Int#to_s(base)` for `base = 62` (thanks @jhass)
* `JSON.parse` now returns `JSON::Any`, which allows traversal of JSON objects with less casts
* Added `OpenSSL::PKCS5` (thanks @benoist)
* MemoryIO can now be created to read/write from a Slice(UInt8). In this mode MemoryIO can't be exapnded, and can optionally be written. And when creating a MemoryIO from a String, it's non-resizeable and read-only.
* MemoryIO can now be created to read/write from a Slice(UInt8). In this mode MemoryIO can't be expanded, and can optionally be written. And when creating a MemoryIO from a String, it's non-resizeable and read-only.
* Added `Object#!~` (the opposite of `=~`)
* `at_exit` now receives that exit status code in the block (thanks @MakeNowJust)
* Allow using `Set` in JSON mappings (thanks @benoist)
Expand All @@ -4498,7 +4498,7 @@

## 0.9.0 (2015-10-16)

* **(breaking change)** The `CGI` module's funcionality has been moved to `URI` and `HTTP::Params`
* **(breaking change)** The `CGI` module's functionality has been moved to `URI` and `HTTP::Params`
* **(breaking change)** `IO#read()` is now `IO#gets_to_end`. Removed `IO#read(count)`, added `IO#skip(count)`
* **(breaking change)** `json_mapping` is now `JSON.mapping`. `yaml_mapping` is now `YAML.mapping`
* **(breaking change)** `StringIO` is now `MemoryIO`
Expand Down Expand Up @@ -4571,7 +4571,7 @@
* Added `HTTP::Cookies` (thanks @netfeed)
* Added `Tuple#reverse` (thanks @jhass)
* Added `Number#clamp` (thanks @technorama)
* Added serveral socket options (thanks @technorama)
* Added several socket options (thanks @technorama)
* Added `WebSocket.open` (thanks @kumpelblase2)
* Added `Enum.flags` macro
* Added support for sending chunked content in HTTP server (thanks @bcardiff)
Expand Down Expand Up @@ -4774,15 +4774,15 @@
* Added `crystal init` to quickly create a skeleton library or application (thanks @waterlink)
* Added `--emit` flag to the compiler. Now you can easily see the generated LLVM IR, LLVM bitcode, assembly and object files.
* Added `--no-color` flag to suppress color output, useful for editor tools.
* Added macro vars: `%var` and `%var{x, y}` create uniqely named variables inside macros.
* Added macro vars: `%var` and `%var{x, y}` create uniquely named variables inside macros.
* Added [typed splats](https://github.com/crystal-lang/crystal/issues/291).
* Added `Iterator` and many methods that return iterators, like `Array#each`, `Hash#each`, `Int#times`, `Int#step`, `String#each_char`, etc.
* Added `sprintf` and improved `String#%` to support floats and float formatting.
* Added more variants of `String#gsub`.
* Added `Pointer#clear` and use it to clear an `Array`'s values when doing `pop` and other shrinking methods.
* Added `BigInt#to_s(base)`, `BigInt::cast` and bit operators (thanks @Exilor)
* Allow invoking methods on a union class as long as all types in the union have it.
* Allow specifying a def's return type. The compiler checks the return type only for that def for now (not for subclasses overrding the method). The return type appears in the documentation.
* Allow specifying a def's return type. The compiler checks the return type only for that def for now (not for subclasses overriding the method). The return type appears in the documentation.
* Allow constants and computed constants for a StaticArray length.
* Allow class vars in enums.
* Allow private and protected defs in enums.
Expand Down Expand Up @@ -4932,7 +4932,7 @@
* Added `Regex.escape`.
* Added `String#scan`.
* Added `-e` switch to spec, to run specs that match a pattern.
* Added `--fail-fast` swtich to spec.
* Added `--fail-fast` switch to spec.
* Added `HTTPClient#basic_auth`.
* Added `DeclareVar`, `Def` and `Arg` macro methods.
* Added `Time` and `TimeSpan` structs. `TimeWithZone` will come later.
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Issue tracker labels are sorted by category: community, kind, pr, status and top

These are the issues where help from the community is most welcome. See above for a description on `newcomer`, `to-research`, `to-design`, `to-implement` and `to-document`.

Label `in-progress` is used to signal that someone from the community is already working on the issue (since Github does not allow for a non-team member to be _assigned_ to an issue).
Label `in-progress` is used to signal that someone from the community is already working on the issue (since GitHub does not allow for a non-team member to be _assigned_ to an issue).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brand


The label `shard-idea` refers to a feature proposal that, albeit good, is better suited as a separate shard rather than as part of the core library; so if you are looking for a shard of your own to start working on, these issues are good starting points.

Expand Down
4 changes: 2 additions & 2 deletions samples/egrep.cr
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ if ARGV.empty?
abort "Usage: cat somefile | egrep 'some'"
end

regx = Regex.new(ARGV[0])
regex = Regex.new(ARGV[0])
while str = STDIN.gets
STDOUT.print(str) if str =~ regx
STDOUT.print(str) if str =~ regex
end
2 changes: 1 addition & 1 deletion spec/compiler/codegen/class_var_spec.cr
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,7 @@ describe "Codegen: class var" do
)).to_i.should eq(1)
end

it "codegens generic class class var" do
it "codegens generic class with class var" do
jsoref marked this conversation as resolved.
Show resolved Hide resolved
run(%(
class Foo(T)
@@bar = 1
Expand Down
2 changes: 1 addition & 1 deletion spec/compiler/semantic/generic_class_spec.cr
Original file line number Diff line number Diff line change
Expand Up @@ -654,7 +654,7 @@ describe "Semantic: generic class" do
)) { nilable int32 }
end

it "doesn't duplicate overload on generic class class method (#2385)" do
it "doesn't duplicate overload on generic class with class method (#2385)" do
jsoref marked this conversation as resolved.
Show resolved Hide resolved
error = assert_error <<-CR
class Foo(T)
def self.foo(x : Int32)
Expand Down
2 changes: 1 addition & 1 deletion spec/compiler/semantic/if_spec.cr
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ describe "Semantic: if" do
assert_type("if 1 == 1; 1; else; 'a'; end", inject_primitives: true) { union_of(int32, char) }
end

it "types and if with and and assignment" do
it "types `if` with `&&` and assignment" do
assert_type("
struct Number
def abs
Expand Down
2 changes: 1 addition & 1 deletion spec/compiler/semantic/while_spec.cr
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ describe "Semantic: while" do
)) { int32 }
end

it "restricts type after while with not and and (#4242)" do
it "restricts type after `while` with `not` and `and` (#4242)" do
jsoref marked this conversation as resolved.
Show resolved Hide resolved
assert_type(%(
a = nil
b = nil
Expand Down
2 changes: 1 addition & 1 deletion spec/std/base64_spec.cr
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ describe "Base64" do
end
end

describe "scrict" do
describe "strict" do
it "encode" do
assert_prints base64_strict_encode("Now is the time for all good coders\nto learn Crystal"),
"Tm93IGlzIHRoZSB0aW1lIGZvciBhbGwgZ29vZCBjb2RlcnMKdG8gbGVhcm4gQ3J5c3RhbA=="
Expand Down
12 changes: 6 additions & 6 deletions spec/std/file_utils_spec.cr
Original file line number Diff line number Diff line change
Expand Up @@ -294,15 +294,15 @@ describe "FileUtils" do
end
end

it "doesn't return error on non existing file" do
it "doesn't return error on nonexistent file" do
jsoref marked this conversation as resolved.
Show resolved Hide resolved
with_tempfile("rm_rf-nonexistent") do |path|
test_with_string_and_path(path) do |arg|
FileUtils.rm_rf(arg).should be_nil
end
end
end

it "doesn't return error on non existing files" do
it "doesn't return error on nonexistent files" do
with_tempfile("rm_rf-nonexistent") do |path1|
path2 = File.join(path1, "a")
test_with_string_and_path(path1, path2) do |*args|
Expand Down Expand Up @@ -468,7 +468,7 @@ describe "FileUtils" do
end
end

it "tests rmdir with an non existing path" do
it "tests rmdir with an nonexistent path" do
with_tempfile("rmdir-nonexistent") do |path|
test_with_string_and_path(path) do |arg|
expect_raises(File::NotFoundError, "Unable to remove directory: '#{path.inspect_unquoted}'") do
Expand All @@ -478,7 +478,7 @@ describe "FileUtils" do
end
end

it "tests rmdir with multiple non existing path" do
it "tests rmdir with multiple nonexistent path" do
with_tempfile("rmdir-nonexistent") do |path|
test_with_string_and_path("#{path}1", "#{path}2") do |*args|
expect_raises(File::NotFoundError, "Unable to remove directory: '#{path.inspect_unquoted}1'") do
Expand Down Expand Up @@ -514,7 +514,7 @@ describe "FileUtils" do
end
end

it "tests rm with non existing path" do
it "tests rm with nonexistent path" do
with_tempfile("rm-nonexistent") do |path|
test_with_string_and_path(path) do |arg|
expect_raises(File::NotFoundError, "Error deleting file: '#{path.inspect_unquoted}'") do
Expand All @@ -536,7 +536,7 @@ describe "FileUtils" do
end
end

it "tests rm with some non existing paths" do
it "tests rm with some nonexistent paths" do
with_tempfile("rm-nonexistent1", "rm-nonexistent2") do |path1, path2|
test_with_string_and_path(path1, path2) do |arg1, arg2|
File.write(path1, "")
Expand Down
4 changes: 2 additions & 2 deletions spec/std/html_spec.cr
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ describe "HTML" do
end

it "unescapes with invalid entities" do
str = HTML.unescape("&&lt;&amp&gt;&quot&abcdefghijklmn &ThisIsNotAnEntitiy;")
str = HTML.unescape("&&lt;&amp&gt;&quot&abcdefghijklmn &ThisIsNotAnEntity;")

str.should eq("&<&>\"&abcdefghijklmn &ThisIsNotAnEntitiy;")
str.should eq("&<&>\"&abcdefghijklmn &ThisIsNotAnEntity;")
end

it "unescapes hex encoded chars" do
Expand Down
4 changes: 2 additions & 2 deletions src/compiler/crystal/codegen/exception.cr
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,8 @@ class Crystal::CodeGenVisitor
# If the rescue restriction matches, codegen the rescue block.
position_at_end this_rescue_block

# On windows, we are "inside" the catchpad block. It's difficult to track when to catchret when
# codegenning the entire rescue body, so we catchret early and execute the rescue bodies "outside" the
# On windows, we are "inside" the catchpad block. It's difficult to track when to catch_ret when
# codegenning the entire rescue body, so we catch_ret early and execute the rescue bodies "outside" the
# rescue block.
if catch_pad = @catch_pad
catch_ret_target_block = new_block "this_rescue_target"
Comment on lines -186 to 190
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to drop, but this matches the use...

Expand Down
2 changes: 1 addition & 1 deletion src/compiler/crystal/interpreter/compiler.cr
Original file line number Diff line number Diff line change
Expand Up @@ -2553,7 +2553,7 @@ class Crystal::Repl::Compiler < Crystal::Visitor
index, type = local_var.index, local_var.type
pointerof_var(index, node: node)
in ClosuredVar
node.raise "BUG: missing interpter out closured var"
node.raise "BUG: missing interpreter out closured var"
end
when InstanceVar
compile_pointerof_ivar(node, exp.name)
Expand Down
2 changes: 1 addition & 1 deletion src/compiler/crystal/interpreter/context.cr
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ class Crystal::Repl::Context
end
end

# This returns the CompiledDef that correspnds to __crystal_raise_overflow
# This returns the CompiledDef that corresponds to __crystal_raise_overflow
getter(crystal_raise_overflow_compiled_def : CompiledDef) do
call = Call.new(nil, "__crystal_raise_overflow", global: true)
program.semantic(call)
Expand Down
2 changes: 1 addition & 1 deletion src/compiler/crystal/interpreter/instructions.cr
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ require "./repl"
# This is the list of every VM instruction.
#
# An instruction consists of:
# - a name/opcode: the name is only for debugging purpsoes, in the bytecode
# - a name/opcode: the name is only for debugging purposes, in the bytecode
# (bytes) it's just a number (a byte)
# - operands: (default: []) values in the bytecode following the opcode.
# For example a `pop` instruction has an operand that tells it how many
Expand Down
Loading