Fix spelling #12040

jsoref · 2022-05-01T23:14:41Z

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@c8485a3#commitcomment-72631828

The action reports that the changes in this PR would make it happy: jsoref@a086ddd

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

jsoref

Most corrections were automatically suggested by Google Sheets.
Duplicate word handling is entirely me. All fault is mine.

jsoref · 2022-05-01T23:15:24Z

CHANGELOG.md

-* `Time` now honours Dayling Saving and `ENV["TZ"]`
+* `Time` now honours Daylight Saving and `ENV["TZ"]`


Notable change.

Some projects don't like retroactively changing changelogs, if this is one, just let me know.

I prefer fixing such typos in the changelog. Thanks!

jsoref · 2022-05-01T23:15:30Z

CHANGELOG.md

-* `HTML`: `HTLM.escape` includes more characters (thanks @Ryuuzakis)
+* `HTML`: `HTML.escape` includes more characters (thanks @Ryuuzakis)


jsoref · 2022-05-01T23:15:43Z

CONTRIBUTING.md

-Label `in-progress` is used to signal that someone from the community is already working on the issue (since Github does not allow for a non-team member to be _assigned_ to an issue).
+Label `in-progress` is used to signal that someone from the community is already working on the issue (since GitHub does not allow for a non-team member to be _assigned_ to an issue).


lib/markd/README.md

spec/compiler/codegen/class_var_spec.cr

src/compiler/crystal/tools/playground/public/settings.js

jsoref · 2022-05-01T23:22:29Z

src/compiler/crystal/tools/playground/public/session.js

-      .append(this.modalContenDom = $("<div>").addClass("modal-content"))
+      .append(this.modalContentDom = $("<div>").addClass("modal-content"))


src/crystal/dwarf/abbrev.cr

jsoref · 2022-05-01T23:23:38Z

src/http/client.cr

-  # Executes a request request and yields an `HTTP::Client::Response` to the block.
+  # Executes a request and yields an `HTTP::Client::Response` to the block.


jsoref · 2022-05-01T23:23:56Z

src/http/cookie.cr

-        # "!#$%&'*+-.0123456789ABCDEFGHIJKLMNOPQRSTUWVXYZ^_`abcdefghijklmnopqrstuvwxyz|~"
+        # "!#$%&'*+-.0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ^_`abcdefghijklmnopqrstuvwxyz|~"


-UWVX +UVWX

lib/markd/README.md

Signed-off-by: Josh Soref <[email protected]>

spec/compiler/semantic/while_spec.cr

spec/compiler/codegen/class_var_spec.cr

spec/compiler/semantic/generic_class_spec.cr

spec/compiler/semantic/while_spec.cr

straight-shoota

Thank you very much for this great work! It's nice to see that you didn't just run some automation over the code base but vetted every single change it suggested.

straight-shoota · 2022-05-03T13:21:40Z

CHANGELOG.md

-* `Time` now honours Dayling Saving and `ENV["TZ"]`
+* `Time` now honours Daylight Saving and `ENV["TZ"]`


I prefer fixing such typos in the changelog. Thanks!

spec/compiler/semantic/if_spec.cr

spec/compiler/semantic/while_spec.cr

src/compiler/crystal/tools/playground/public/settings.js

src/crystal/dwarf/abbrev.cr

src/io/overlapped.cr

Signed-off-by: Josh Soref <[email protected]>

beta-ziliani

🚀 thanks!

This instance of the spelling mistake was not detected by crystal-lang#12040 for some reason, so that PR broke the playground when something fails to build.

jsoref commented May 1, 2022

View reviewed changes

caspiano reviewed May 2, 2022

View reviewed changes

lib/markd/README.md Outdated Show resolved Hide resolved

Blacksmoke16 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:docs labels May 2, 2022

jsoref added 4 commits May 1, 2022 21:37

spelling: abcdefghijklmnopqrstuvwxyz

07a39ed

Signed-off-by: Josh Soref <[email protected]>

spelling: address

2d21aeb

Signed-off-by: Josh Soref <[email protected]>

spelling: all

a5c32f5

Signed-off-by: Josh Soref <[email protected]>

spelling: allocation

f6df735

Signed-off-by: Josh Soref <[email protected]>

jsoref force-pushed the spelling branch from 2c7c293 to b5bc7d5 Compare May 2, 2022 01:39

yxhuvud reviewed May 2, 2022

View reviewed changes

spec/compiler/semantic/while_spec.cr Outdated Show resolved Hide resolved

jsoref force-pushed the spelling branch from b5bc7d5 to b1abbed Compare May 2, 2022 21:57

jsoref commented May 2, 2022

View reviewed changes

spec/compiler/codegen/class_var_spec.cr Show resolved Hide resolved

spec/compiler/semantic/generic_class_spec.cr Show resolved Hide resolved

spec/compiler/semantic/while_spec.cr Show resolved Hide resolved

straight-shoota self-requested a review May 2, 2022 22:36

straight-shoota reviewed May 3, 2022

View reviewed changes

jsoref added 16 commits May 3, 2022 12:58

spelling: and

c7f1682

Signed-off-by: Josh Soref <[email protected]>

spelling: another

1df649d

Signed-off-by: Josh Soref <[email protected]>

spelling: appropriate

f64ee65

Signed-off-by: Josh Soref <[email protected]>

spelling: assigning

99d6dab

Signed-off-by: Josh Soref <[email protected]>

spelling: can

db98566

Signed-off-by: Josh Soref <[email protected]>

spelling: catch_ret

51ece83

Signed-off-by: Josh Soref <[email protected]>

spelling: class

d7bce1c

Signed-off-by: Josh Soref <[email protected]>

spelling: content

4e69a51

Signed-off-by: Josh Soref <[email protected]>

spelling: conversion

ae9d9b2

Signed-off-by: Josh Soref <[email protected]>

spelling: corresponds

9e8026e

Signed-off-by: Josh Soref <[email protected]>

spelling: daylight

bc6251c

Signed-off-by: Josh Soref <[email protected]>

spelling: decimal

4855823

Signed-off-by: Josh Soref <[email protected]>

spelling: emojis

fda4f64

Signed-off-by: Josh Soref <[email protected]>

spelling: enabled

136b9b2

Signed-off-by: Josh Soref <[email protected]>

spelling: entity

f273f49

Signed-off-by: Josh Soref <[email protected]>

spelling: ephemeral

755f277

Signed-off-by: Josh Soref <[email protected]>

jsoref added 20 commits May 3, 2022 12:58

spelling: interpreter

a5722a4

Signed-off-by: Josh Soref <[email protected]>

spelling: intrinsic

8f91153

Signed-off-by: Josh Soref <[email protected]>

spelling: nonexistent

fa6e32c

Signed-off-by: Josh Soref <[email protected]>

spelling: opening

50a4fbc

Signed-off-by: Josh Soref <[email protected]>

spelling: overriding

c2028ad

Signed-off-by: Josh Soref <[email protected]>

spelling: potentially

9546ed4

Signed-off-by: Josh Soref <[email protected]>

spelling: purposes

650b123

Signed-off-by: Josh Soref <[email protected]>

spelling: reachable

c313e73

Signed-off-by: Josh Soref <[email protected]>

spelling: regarding

3dc95d4

Signed-off-by: Josh Soref <[email protected]>

spelling: regex

33d48ef

Signed-off-by: Josh Soref <[email protected]>

spelling: request

729060e

Signed-off-by: Josh Soref <[email protected]>

spelling: room

a6254fc

Signed-off-by: Josh Soref <[email protected]>

spelling: several

031ef7e

Signed-off-by: Josh Soref <[email protected]>

spelling: strict

8ad77d8

Signed-off-by: Josh Soref <[email protected]>

spelling: support

69b4bc6

Signed-off-by: Josh Soref <[email protected]>

spelling: switch

ac8ed50

Signed-off-by: Josh Soref <[email protected]>

spelling: timeout

a11c361

Signed-off-by: Josh Soref <[email protected]>

spelling: uniquely

92ab021

Signed-off-by: Josh Soref <[email protected]>

spelling: with

c311d78

Signed-off-by: Josh Soref <[email protected]>

spelling: workaround

a9b9cc2

Signed-off-by: Josh Soref <[email protected]>

jsoref force-pushed the spelling branch from b1abbed to a9b9cc2 Compare May 3, 2022 16:59

jsoref requested a review from straight-shoota May 3, 2022 22:26

straight-shoota approved these changes May 4, 2022

View reviewed changes

beta-ziliani approved these changes May 20, 2022

View reviewed changes

beta-ziliani added this to the 1.5.0 milestone May 20, 2022

straight-shoota changed the title ~~Spelling~~ Fix spelling May 23, 2022

straight-shoota merged commit 04f1c5a into crystal-lang:master May 23, 2022

jsoref deleted the spelling branch May 23, 2022 12:47

HertzDevil mentioned this pull request Jul 2, 2022

Playground: fix modalContenDom typo #12188

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix spelling #12040

Fix spelling #12040

jsoref commented May 1, 2022

jsoref left a comment

jsoref May 1, 2022

straight-shoota May 3, 2022

jsoref May 1, 2022

jsoref May 1, 2022

jsoref May 1, 2022

jsoref May 1, 2022

jsoref May 1, 2022

straight-shoota left a comment

straight-shoota May 3, 2022

beta-ziliani left a comment

		* `Time` now honours Dayling Saving and `ENV["TZ"]`
		* `Time` now honours Daylight Saving and `ENV["TZ"]`

		* `HTML`: `HTLM.escape` includes more characters (thanks @Ryuuzakis)
		* `HTML`: `HTML.escape` includes more characters (thanks @Ryuuzakis)

		Label `in-progress` is used to signal that someone from the community is already working on the issue (since Github does not allow for a non-team member to be _assigned_ to an issue).
		Label `in-progress` is used to signal that someone from the community is already working on the issue (since GitHub does not allow for a non-team member to be _assigned_ to an issue).

		.append(this.modalContenDom = $("<div>").addClass("modal-content"))
		.append(this.modalContentDom = $("<div>").addClass("modal-content"))

		# Executes a request request and yields an `HTTP::Client::Response` to the block.
		# Executes a request and yields an `HTTP::Client::Response` to the block.

		# "!#$%&'*+-.0123456789ABCDEFGHIJKLMNOPQRSTUWVXYZ^_`abcdefghijklmnopqrstuvwxyz\|~"
		# "!#$%&'*+-.0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ^_`abcdefghijklmnopqrstuvwxyz\|~"

Fix spelling #12040

Fix spelling #12040

Conversation

jsoref commented May 1, 2022

jsoref left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

straight-shoota left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

beta-ziliani left a comment

Choose a reason for hiding this comment