Mark bswap32 instrinsic with interpreter primitive annotation
#11582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
added
kind:bug
straight-shoota
approved these changes
Dec 14, 2021
asterite
approved these changes
Dec 14, 2021
|
I added it to the milestone, and we can add the spec later after #11578 is merged |
straight-shoota
changed the title
bswap32 instrinsic with interpreter primitive annotation
rdp
pushed a commit
to rdp/crystal
that referenced
this pull request
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike bswap16 (and most other intrinsics), bswap32 wasn't marked with the Primitive annotation when in interpreted mode, despite an instruction seemingly existing for it
Discovered while trying to run the compiler in interpreted mode