Split interpreter specs into separate files #11578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
sdogruyol
approved these changes
Dec 13, 2021
|
Interpreter CI has been disabled in #11623. So we can merge this without breaking CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original interpreter specs were amassed in a single spec file with over 6k lines. This patch separates them into individual files. That makes everything easier to handle. Especially considering that we certainly want to grow these specs.
Also adds a main entry point for interpreter specs at
spec/compiler/interpreter_spec.crwhich requires all the individual specs in that folder.