Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default stack size on MSVC to 8 MB #11569

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Increase default stack size on MSVC to 8 MB #11569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
216b3ab
Increase default stack size on MSVC
HertzDevil Dec 11, 2021
8de7249
Merge remote-tracking branch 'upstream/master' into feature/msvc-defa…
HertzDevil Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/win.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,11 +277,11 @@ jobs:
cl /MT /c src\llvm\ext\llvm_ext.cc -I llvm\include /Fosrc\llvm\ext\llvm_ext.obj
- name: Link Crystal executable
run: |
Invoke-Expression "cl crystal.obj /Fecrystal-cross src\llvm\ext\llvm_ext.obj $(llvm\bin\llvm-config.exe --libs) libs\pcre.lib libs\gc.lib WS2_32.lib advapi32.lib libcmt.lib dbghelp.lib ole32.lib shell32.lib legacy_stdio_definitions.lib /link /LIBPATH:$(pwd)\libs /STACK:10000000"
Invoke-Expression "cl crystal.obj /Fecrystal-cross src\llvm\ext\llvm_ext.obj $(llvm\bin\llvm-config.exe --libs) libs\pcre.lib libs\gc.lib WS2_32.lib advapi32.lib libcmt.lib dbghelp.lib ole32.lib shell32.lib legacy_stdio_definitions.lib /link /LIBPATH:$(pwd)\libs /STACK:0x800000"

- name: Re-build Crystal
run: |
.\crystal-cross.exe build src/compiler/crystal.cr -Di_know_what_im_doing -Dwithout_playground -Dwithout_interpreter --link-flags=/STACK:10000000
.\crystal-cross.exe build src/compiler/crystal.cr -Di_know_what_im_doing -Dwithout_playground -Dwithout_interpreter
mv crystal.exe bin/

- name: Gather Crystal binaries
Expand Down
6 changes: 3 additions & 3 deletions spec/compiler/semantic/generic_class_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ describe "Semantic: generic class" do
"use a more specific type"
end

pending_win32 "errors on too nested generic instance" do
it "errors on too nested generic instance" do
assert_error %(
class Foo(T)
end
Expand All @@ -523,7 +523,7 @@ describe "Semantic: generic class" do
"generic type too nested"
end

pending_win32 "errors on too nested generic instance, with union type" do
it "errors on too nested generic instance, with union type" do
assert_error %(
class Foo(T)
end
Expand All @@ -537,7 +537,7 @@ describe "Semantic: generic class" do
"generic type too nested"
end

pending_win32 "errors on too nested tuple instance" do
it "errors on too nested tuple instance" do
assert_error %(
def foo
{typeof(foo)}
Expand Down
2 changes: 1 addition & 1 deletion src/compiler/crystal/compiler.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ module Crystal
{% end %}

link_args << "/DEBUG:FULL /PDBALTPATH:%_PDB%" unless debug.none?
link_args << "/INCREMENTAL:NO"
link_args << "/INCREMENTAL:NO /STACK:0x800000"
link_args << lib_flags
@link_flags.try { |flags| link_args << flags }

Expand Down