Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default stack size on MSVC to 8 MB #11569

Merged

Conversation

HertzDevil
Copy link
Contributor

Makes the stack size on Windows consistent with Fiber as well as the usual ulimit -s value. This reduces the chances that the same program suddenly reaches stack overflow when compiled on Windows, but not on other platforms, for example the compiler itself.

This can be overridden by the same linker option.

@HertzDevil HertzDevil added platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:system topic:compiler and removed topic:stdlib:system labels Dec 11, 2021
@straight-shoota straight-shoota added this to the 1.3.0 milestone Dec 11, 2021
@straight-shoota straight-shoota merged commit 28240b8 into crystal-lang:master Dec 14, 2021
@HertzDevil HertzDevil deleted the feature/msvc-default-stack-size branch December 14, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:windows Windows support based on the MSVC toolchain / Win32 API topic:compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants