Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing macro literal containing char literal #10799

Merged
merged 1 commit into from
Jun 13, 2021
Merged

Fix parsing macro literal containing char literal #10799

merged 1 commit into from
Jun 13, 2021

Conversation

straight-shoota
Copy link
Member

Fixes #10745

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:parser labels Jun 8, 2021
asterite
asterite approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one!

@straight-shoota straight-shoota added this to the 1.1.0 milestone Jun 9, 2021
@straight-shoota straight-shoota merged commit e49bd98 into crystal-lang:master Jun 13, 2021
@straight-shoota straight-shoota deleted the fix/macro-single-quote branch June 13, 2021 20:06
@straight-shoota straight-shoota mentioned this pull request Jul 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:parser
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Char literal with single quote inside macro def breaks the parser
2 participants
@straight-shoota @asterite