Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Char literal with single backslash inside macro def breaks the parser #10991

Closed
lbguilherme opened this issue Jul 23, 2021 · 1 comment · Fixed by #10995
Closed

Char literal with single backslash inside macro def breaks the parser #10991

lbguilherme opened this issue Jul 23, 2021 · 1 comment · Fixed by #10995
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:regression Something that used to correctly work but no longer works topic:compiler:parser
Milestone
1.1.1

Comments

@lbguilherme
Copy link
Contributor 

macro borked # Error: unterminated macro
  '\\'
end

Very similar to #10745.
Causes Papierkorb/toka#3.

This is a regression, the same code works on Crystal 1.0.0.
@lbguilherme lbguilherme added the kind:bug A bug in the code. Does not apply to documentation, specs, etc. label Jul 23, 2021
@straight-shoota straight-shoota added topic:compiler:parser kind:regression Something that used to correctly work but no longer works labels Jul 23, 2021
@straight-shoota
Copy link
Member

Yeah, this looks like a regression introduced by #10799. Before that, it was already broken for string literals, though.

@straight-shoota straight-shoota mentioned this issue Jul 23, 2021
Merged
@straight-shoota straight-shoota added this to the 1.1.1 milestone Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:regression Something that used to correctly work but no longer works topic:compiler:parser
Projects
None yet
Milestone
1.1.1
Development

Successfully merging a pull request may close this issue.

Fix parsing macro body with escaped backslash in literal straight-shoota/crystal
2 participants
@straight-shoota @lbguilherme