Add WinError.wsa_value and specs for WinError
#10762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
added
kind:feature
platform:windows
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds
WinError.wsa_valuewhich returns the last error value of the Windows Socket API fromWSAGetLastError.This is a follow-up on #10726 which already references
WinError.wsa_valuefromSystemError.from_wsa_error. Because it's not used yet (but soon!), this wasn't caught. To remedy this, I'm also adding specs forWinError.Writing proper specs requires setting the error value, so I also added setters to
WinError, for both the win32 and WSA error values. We also expose these setters onErrno, the POSIX-companion ofWinError, so I think it makes sense to have them here, too.