Improve portability of SystemError
#10726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
changed the title
WinError portable and improve portability of SystemErrorSystemError
straight-shoota
force-pushed
the
refactor/system-error
branch
from
4583305 to
929f32a
Compare
|
Rebased on top of #10725 and ready for review. |
3 tasks
beta-ziliani
approved these changes
May 26, 2021
|
Mmm... why so many reds in the CI? |
|
'cause I gsubbed once too many 😆 |
|
once it's all green again, this is good to go in my opinion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10720
This PR builts upon #10725 which needs to be merged first. The first two commits belong to that.
I'm posting them independently to clearly separate the two stages and keep the discussion focused.
SystemErrorgets a more portable API, which now consists of these main methods:.from_os_error(message : String?, os_error = Errno | WinError | Nil, **opts)replaces the platform-specific.from_errnoand.from_winerrormethods receivingErrnoandWinErrorvalues, respectively..from_errno(message : String, **opts)continues the purpose of constructing an instance with the current LibC errno value. It delegates tofrom_os_error(message, Errno.value, **opts)..from_winerror(message : String, **opts)continues the purpose of constructing an instance with the current LibC winerror value. It delegates tofrom_os_error(message, WinError.value, **opts).