Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Corrected build instructions #1996

Merged
merged 7 commits into from
Dec 9, 2022
Merged

Doc: Corrected build instructions #1996

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a485996
fix-build-instructions
relativisticelectron Dec 3, 2022
ab4ed97
set "pip3 install -e ."
relativisticelectron Dec 7, 2022
3ae6f5a
added require-hashes back in
relativisticelectron Dec 7, 2022
34dd6cd
Merge branch 'master' into fix-build-instructions
moneymanolis Dec 8, 2022
0d1a9be
Merge branch 'master' into fix-build-instructions
k9ert Dec 8, 2022
915841b
Merge branch 'master' into fix-build-instructions
moneymanolis Dec 8, 2022
9fdfa0e
Merge branch 'master' into fix-build-instructions
k9ert Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/development.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ pip3 install virtualenv
virtualenv --python=python3 .env
source .env/bin/activate
pip3 install -r requirements.txt --require-hashes
pip3 install -e .
python3 setup.py install # also compiles the babel translation-files
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have thought that the solution here is to remove the python3 setup.py install but keep pip3 install -e .?! After all the compilation of the babel translation-files is not necessary for a dev-env, imho?!

Copy link
Collaborator Author

@relativisticelectron relativisticelectron Dec 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it turns out that keeping pip3 install -e . without python3 setup.py install also works repeatedly (I didn't realize that). I would prefer however build instructions that include babel compilation. What if someone tests translation issues?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus one for pip3 install -e . - works much more reliably. @relativisticelectron if you find someone who tests translation issues I will personally guide this person through his dev setup ;-)

```

Expand Down
4 changes: 3 additions & 1 deletion utils/test-all-linux.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@
pip3 install virtualenv
virtualenv --python=python3 .env
source .env/bin/activate
# removing modules related to cryptoadvance is faster than doing rm -rf .env
pip3 freeze | grep cryptoadvance | xargs pip uninstall -y
pip3 freeze | grep specterext | xargs pip uninstall -y
pip3 install -r requirements.txt --require-hashes
pip3 install -e .
python3 setup.py install # also compiles the babel translation-files


Expand Down