-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc: Corrected build instructions #1996
Doc: Corrected build instructions #1996
Conversation
✅ Deploy Preview for specter-desktop-docs canceled.
|
docs/development.md
Outdated
pip3 install -e . | ||
python3 setup.py install # also compiles the babel translation-files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have thought that the solution here is to remove the python3 setup.py install
but keep pip3 install -e .
?! After all the compilation of the babel translation-files is not necessary for a dev-env, imho?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it turns out that keeping pip3 install -e .
without python3 setup.py install
also works repeatedly (I didn't realize that). I would prefer however build instructions that include babel compilation. What if someone tests translation issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plus one for pip3 install -e .
- works much more reliably. @relativisticelectron if you find someone who tests translation issues I will personally guide this person through his dev setup ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep pip3 install -e .
Done. |
Fix for #1935