Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Corrected build instructions #1996

Merged

Conversation

relativisticelectron
Copy link
Collaborator

Fix for #1935

@netlify
Copy link

netlify bot commented Dec 3, 2022

Deploy Preview for specter-desktop-docs canceled.

Name Link
🔨 Latest commit 9fdfa0e
🔍 Latest deploy log https://app.netlify.com/sites/specter-desktop-docs/deploys/6391fcc70700180008bb20fc

pip3 install -e .
python3 setup.py install # also compiles the babel translation-files
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have thought that the solution here is to remove the python3 setup.py install but keep pip3 install -e .?! After all the compilation of the babel translation-files is not necessary for a dev-env, imho?!

Copy link
Collaborator Author

@relativisticelectron relativisticelectron Dec 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it turns out that keeping pip3 install -e . without python3 setup.py install also works repeatedly (I didn't realize that). I would prefer however build instructions that include babel compilation. What if someone tests translation issues?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus one for pip3 install -e . - works much more reliably. @relativisticelectron if you find someone who tests translation issues I will personally guide this person through his dev setup ;-)

Copy link
Collaborator

@moneymanolis moneymanolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep pip3 install -e .

@relativisticelectron
Copy link
Collaborator Author

Keep pip3 install -e .

Done.

@k9ert k9ert merged commit c7bd49b into cryptoadvance:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants