Fix #1177 #1180
Merged
Fix #1177 #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sjors
reviewed
May 24, 2021
| return ( | ||
| data_dict["addresses"][0] | ||
| if "addresses" in data_dict and data_dict["addresses"][0] | ||
| else data_dict["address"] |
There was a problem hiding this comment.
Maybe put a comment here to drop ["addresses"][0] when you drop support for Bitcoin Core < v22 in the distant future.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check also for
["scriptPubKey"]["address"]to be compatible with Bitcoin Core v22.Fix #1177