Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of ["addresses"] will be deprecated in Bitcoin Core v22 #1177

Closed
Sjors opened this issue May 21, 2021 · 1 comment · Fixed by #1180
Closed

Use of ["addresses"] will be deprecated in Bitcoin Core v22 #1177

Sjors opened this issue May 21, 2021 · 1 comment · Fixed by #1180

Comments

@Sjors
Copy link
Contributor

Sjors commented May 21, 2021

bitcoin/bitcoin#20286

  • The following RPCs: gettxout, getrawtransaction, decoderawtransaction,
    decodescript, gettransaction, and REST endpoints: /rest/tx,
    /rest/getutxos, /rest/block deprecated the following fields (which are no
    longer returned in the responses by default): addresses, reqSigs.
    The -deprecatedrpc=addresses flag must be passed for these fields to be
    included in the RPC response. This flag/option will be available until v23, at which
    point the deprecation will be removed entirely. Note that these fields are attributes of
    the scriptPubKey object returned in the RPC response. However, in the response
    of decodescript these fields are top-level attributes, and included again as attributes
    of the scriptPubKey object. (#20286)

Replacing ['scriptPubKey']['addresses'][0] in wallet_send_sign_psbt.jinja with ['scriptPubKey']['address'] seems to do the trick.

ben-kaufman added a commit to ben-kaufman/specter-desktop that referenced this issue May 23, 2021
@ben-kaufman ben-kaufman mentioned this issue May 23, 2021
@ben-kaufman
Copy link
Contributor

Thanks for the heads up, I've made this PR to check for this field when the addresses isn't found #1180

ben-kaufman added a commit that referenced this issue May 25, 2021
* Fix #1177

* Use helper function and fix missing places

* Add comment to remove eventually

* Fix tx details popup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants