Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling #194

Merged
merged 15 commits into from
Jul 17, 2024
Merged

Improve error handling #194

merged 15 commits into from
Jul 17, 2024

Conversation

Samirkhairati
Copy link
Contributor

  1. Disabled edit and copy frontend Icons for archived timetables in view/edit timetable pages
  2. Improved 404 page design and extracted it to a component
  3. Removed zod validation for minimum characters for timetable ID for consistency
  4. Redirect to 404 page when viewing or editing timetables that do not exist

Closes #189

skoriop
skoriop requested changes Jul 17, 2024
View reviewed changes
Copy link
Member

@skoriop skoriop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good if we still displayed tooltips for the disabled buttons explaining why they're disabled (for example, Archived timetables cannot be copied).

Apart from that, a couple of pretty small fixes here and there.

frontend/src/ViewTimetable.tsx Outdated Show resolved Hide resolved
frontend/src/components/announcements.tsx Show resolved Hide resolved
frontend/src/components/announcements.tsx Show resolved Hide resolved
frontend/src/components/NotFound.tsx Show resolved Hide resolved
frontend/src/components/announcements.tsx Show resolved Hide resolved
frontend/src/components/NotFound.tsx Show resolved Hide resolved
Samirkhairati and others added 4 commits July 17, 2024 20:46
@Samirkhairati
feat: Show not-allowed cursor + tooltip for editing/copying archived …
961952a 
…timetables
@Samirkhairati
fix: remove the go home button, make the NotFound component fit in th…
7f7eebd 
…e remaining screen height
@skoriop
fix: fix tooltip classnames
0bde737 
if the timetable is not archived, the `&&` will result in `false`, which is not a Tailwind class that we want to be applying.
@skoriop
fix: fix endpoint path
dd83b99 
not sure why this sometimes works and sometimes doesn't
@skoriop skoriop self-requested a review July 17, 2024 18:14
skoriop
skoriop approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@skoriop skoriop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skoriop skoriop added the ready Ready to be merged (used by our GitHub Actions pipeline) label Jul 17, 2024
@skoriop skoriop added this pull request to the merge queue Jul 17, 2024
Merged via the queue into master with commit 8ce266d Jul 17, 2024
1 check passed
@skoriop skoriop deleted the improve-error-handling branch July 18, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skoriop skoriop skoriop approved these changes

Assignees
No one assigned
Labels
ready Ready to be merged (used by our GitHub Actions pipeline)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error handling
2 participants
@Samirkhairati @skoriop