Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling #189

Closed
3 tasks done
skoriop opened this issue Jun 25, 2024 · 0 comments · Fixed by #194
Closed
3 tasks done

Improve error handling #189

skoriop opened this issue Jun 25, 2024 · 0 comments · Fixed by #194
Assignees

Comments

@skoriop
Copy link
Member

skoriop commented Jun 25, 2024

There are a couple of minor fixes we should do to improve our error handling in general. Ideally, we want to stop the user from doing common error-causing actions on the frontend, and in the case of unexpected errors we want to display them better.

Here are some of them:

  • Disable frontend icons for editing and copying a timetable if the timetable is archived in ViewTimetable.tsx and add a tooltip telling them it's not allowed
  • Make a better-looking 404 page (NotFound.tsx)
  • Trying to view / edit timetables that do not exist (like this) should redirect to the 404 page
    • The reason for the 400 is because of Zod's validation. If it's possible, we should redirect them to the 404 page. If not, it's probably best to remove that check and handle it in the backend.
@skoriop skoriop converted this from a draft issue Jun 25, 2024
@skoriop skoriop mentioned this issue Jun 25, 2024
5 tasks
@skoriop skoriop moved this from Ready to In progress in ChronoFactorem Release v1.1.0 Jul 17, 2024
@skoriop skoriop moved this from In progress to In review in ChronoFactorem Release v1.1.0 Jul 17, 2024
@skoriop skoriop moved this from In review to In progress in ChronoFactorem Release v1.1.0 Jul 17, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in ChronoFactorem Release v1.1.0 Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants