Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change buildId type to int in download_project_translations #50

Merged
merged 2 commits into from
Oct 1, 2022
Merged

Change buildId type to int in download_project_translations #50

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6edee04
Change buildId type to int in download_project_translations
aaj013 Oct 1, 2022
e94e070
Change buildId type to int in TranslationsResource
aaj013 Oct 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions crowdin_api/api_resources/translations/resource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class TranslationsResource(BaseResource):
https://developer.crowdin.com/api/v2/#tag/Translations
"""

def get_builds_path(self, projectId: int, buildId: Optional[str] = None):
def get_builds_path(self, projectId: int, buildId: Optional[int] = None):
if buildId:
return f"projects/{projectId}/translations/builds/{buildId}"

Expand Down Expand Up @@ -261,7 +261,7 @@ def upload_translation(
},
)

def download_project_translations(self, projectId: int, buildId: str):
def download_project_translations(self, projectId: int, buildId: int):
"""
Download Project Translations.

Expand All @@ -274,7 +274,7 @@ def download_project_translations(self, projectId: int, buildId: str):
path=f"{self.get_builds_path(projectId=projectId, buildId=buildId)}/download",
)

def check_project_build_status(self, projectId: int, buildId: str):
def check_project_build_status(self, projectId: int, buildId: int):
"""
Check Project Build Status.

Expand All @@ -287,7 +287,7 @@ def check_project_build_status(self, projectId: int, buildId: str):
path=self.get_builds_path(projectId=projectId, buildId=buildId),
)

def cancel_build(self, projectId: int, buildId: str):
def cancel_build(self, projectId: int, buildId: int):
"""
Cancel Build.

Expand Down