Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change buildId type to int in download_project_translations #50

Conversation

aaj013
Copy link
Contributor

@aaj013 aaj013 commented Oct 1, 2022

Closes #49

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2022

Codecov Report

Merging #50 (e94e070) into main (9419ff7) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   98.65%   98.65%           
=======================================
  Files          99       99           
  Lines        1993     1993           
  Branches      248      248           
=======================================
  Hits         1966     1966           
  Misses         21       21           
  Partials        6        6           
Impacted Files Coverage Δ
crowdin_api/api_resources/translations/resource.py 97.50% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@andrii-bodnar
Copy link
Member

@aaj013 thanks a lot for your contribution!

There are a few more places in this class where the buildId has a string type. Could you please fix these places also?

@andrii-bodnar andrii-bodnar self-requested a review October 1, 2022 13:42
@andrii-bodnar andrii-bodnar added the hacktoberfest This issue welcomes contributions for Hacktoberfest label Oct 1, 2022
@aaj013
Copy link
Contributor Author

aaj013 commented Oct 1, 2022

@aaj013 thanks a lot for your contribution!

There are a few more places in this class where the buildId has a string type. Could you please fix these places also?

Done!

@andrii-bodnar andrii-bodnar merged commit 6e9589e into crowdin:main Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest This issue welcomes contributions for Hacktoberfest hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid signature for method download_project_translations
3 participants