Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for GraphQL endpoint #189

Merged

Conversation

imprvhub
Copy link
Contributor

@imprvhub imprvhub commented Dec 2, 2024

-Add GraphQL method to CrowdinClient for interfacing with the GraphQL endpoint.
-The implementation supports query strings and optional variables.
-Includes comprehensive test coverage for request validation.

Implements #180

imprvhub and others added 3 commits November 27, 2024 23:47
feat: add addToTm parameter support for Upload Translation API (crowdin#185)
Merge #2 feat(api): Add croql parameter support to List Terms API
-Add GraphQL method to CrowdinClient for interfacing with the GraphQL endpoint.
-The implementation supports query strings and optional variables.
-Includes comprehensive test coverage for request validation.

Implements crowdin#180
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.23%. Comparing base (4e5eeb6) to head (2cb8e92).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
+ Coverage   99.21%   99.23%   +0.02%     
==========================================
  Files         166      166              
  Lines        6519     6675     +156     
  Branches      149      149              
==========================================
+ Hits         6467     6623     +156     
  Misses         36       36              
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imprvhub
Copy link
Contributor Author

imprvhub commented Dec 2, 2024

@andrii-bodnar PR ready for review!

@andrii-bodnar andrii-bodnar linked an issue Dec 3, 2024 that may be closed by this pull request
@andrii-bodnar
Copy link
Member

@imprvhub thanks for the contribution!

Please add documentation about this endpoint to the Readme file.

As a reference, see the JS API Client Readme.

-Add GraphQL method to CrowdinClient for interfacing with the GraphQL endpoint.
-The implementation supports query strings and optional variables.
-Includes comprehensive test coverage for request validation.
-Add documentation for GraphQL API usage in README.
@imprvhub
Copy link
Contributor Author

imprvhub commented Dec 3, 2024

@andrii-bodnar As requested, I have included the GraphQL API documentation in the README as part of the implementation commit fc0648f.

Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imprvhub thank you!

README.md Outdated Show resolved Hide resolved
@andrii-bodnar andrii-bodnar merged commit f3ca4c5 into crowdin:main Dec 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the GraphQL endpoint support
3 participants