feat: add addToTm parameter support for Upload Translation API #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The support for addToTm parameter has been added to upload_translation method: - Defined addToTm in UploadTranslationRequest type - Added addToTm as optional boolean parameter in upload_translation - Added comprehensive test cases covering all possible scenarios Default value (true) is handled by the API as specified in: https://developer.crowdin.com/api/v2/#operation/api.projects.translations.postOnLanguage Closes crowdin#183
|
@andrii-bodnar Fixed indentation issues from #185 that were causing workflow failures. All style checks should pass now. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
==========================================
+ Coverage 99.20% 99.21% +0.01%
==========================================
Files 166 166
Lines 6497 6505 +8
Branches 149 149
==========================================
+ Hits 6445 6453 +8
Misses 36 36
Partials 16 16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
@imprvhub thanks for your contribution!
I just left a few comments on the matter.
andrii-bodnar
approved these changes
Nov 27, 2024
imprvhub
added a commit
to imprvhub/crowdin-api-client-python
that referenced
this pull request
Nov 28, 2024
feat: add addToTm parameter support for Upload Translation API (crowdin#185)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support for addToTm parameter has been added to upload_translation method:
Default value (true) is handled by the API as specified in: https://developer.crowdin.com/api/v2/#operation/api.projects.translations.postOnLanguage
Closes #183