Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Add croql parameter support to List Terms API #188

Merged
merged 2 commits into from
Nov 30, 2024

Conversation

imprvhub
Copy link
Contributor

Added support for filtering terms using CroQL query parameter in the List Terms API endpoint.

Changes:

  • Added croql parameter to list_terms method
  • Updated test suite with new test cases for CroQL filtering
  • Maintained compatibility with existing query parameters

Closes #182

imprvhub and others added 2 commits November 27, 2024 23:47
feat: add addToTm parameter support for Upload Translation API (crowdin#185)
Added support for filtering terms using CroQL query parameter in the List Terms API endpoint. This implementation includes:

- Added croql parameter to list_terms method
- Updated test suite with new test cases for CroQL filtering
- Maintained compatibility with existing query parameters

Related issue: crowdin#182
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.21%. Comparing base (ef7cfb1) to head (7a1ba16).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
+ Coverage   99.20%   99.21%   +0.01%     
==========================================
  Files         166      166              
  Lines        6497     6519      +22     
  Branches      149      149              
==========================================
+ Hits         6445     6467      +22     
  Misses         36       36              
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imprvhub thank you!

@andrii-bodnar andrii-bodnar merged commit 4e5eeb6 into crowdin:main Nov 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List Terms API: add croql parameter support
3 participants