-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unit tests for python 3.12 #128
Conversation
Hi @rsk2, the pipeline is failing - https://github.com/crowdin/crowdin-api-client-python/actions/runs/6458990551 could you please take a look? |
@andrii-bodnar, I am not sure how to proceed. There doesn't seem to be any difference between the actual and expected values. Can you please take a look? |
@rsk2 it's because of the |
@andrii-bodnar ok. What do you suggest as the solution for this? |
@rsk2 I'm not sure actually, it requires more investigation |
I think it should be properly tested for |
@rsk2 Please try to do something like this to suppress the deprecation warning in tests: import warnings
def my_test_function():
# ...
warnings.filterwarnings('ignore', 'Call to deprecated method generate_simple_cost_estimate_report')
# Call the deprecated method
generate_simple_cost_estimate_report()
# ...
if __name__ == '__main__':
my_test_function() |
or |
@andrii-bodnar Ok, I see that you are addressing the deprecation warnings in the tests. But what about the one failed test? Please see screenshot below: |
@rsk2 I see that the pipeline is almost passing 🙂 Maybe, there is an issue with the However, the error message you're seeing indicates that the
|
Codecov Report
@@ Coverage Diff @@
## main #128 +/- ##
==========================================
+ Coverage 99.19% 99.20% +0.01%
==========================================
Files 146 146
Lines 5056 5066 +10
Branches 710 710
==========================================
+ Hits 5015 5025 +10
Misses 29 29
Partials 12 12
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rsk2 thank you! 🚀
@andrii-bodnar thank you! |
Fixes Fix Unit tests for Python 3.12 #127