Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Unit tests for Python 3.12 #127

Closed
andrii-bodnar opened this issue Oct 9, 2023 · 1 comment · Fixed by #128
Closed

Fix Unit tests for Python 3.12 #127

andrii-bodnar opened this issue Oct 9, 2023 · 1 comment · Fixed by #128
Assignees
@rsk2
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest This issue welcomes contributions for Hacktoberfest

Comments

@andrii-bodnar
Copy link
Member

I added version 3.12 to the CI/CD pipeline in #126 and some tests failed.

https://github.com/crowdin/crowdin-api-client-python/actions/runs/6453647001/job/17517596970

We need to fix these tests to run successfully on 3.12.
@andrii-bodnar andrii-bodnar added bug Something isn't working good first issue Good for newcomers hacktoberfest This issue welcomes contributions for Hacktoberfest labels Oct 9, 2023
@rsk2
Copy link
Contributor

rsk2 commented Oct 9, 2023

Hi @andrii-bodnar, I am interested in working on this issue. It looks like using assert_called_once_with will fix the test.

@rsk2 rsk2 mentioned this issue Oct 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rsk2 rsk2

Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest This issue welcomes contributions for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: unit tests for python 3.12 rsk2/crowdin-api-client-python
2 participants
@andrii-bodnar @rsk2